Skip to content

Fix build on Windows: parameter shadowed volumeNameLen in cleanGlobPath #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrews54757 merged 1 commit into from
Sep 9, 2026
Merged

Fix build on Windows: parameter shadowed volumeNameLen in cleanGlobPath #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions miniglob.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ const volumeNameLen = WIN32 ? (path) => {
// cleanGlobPath(path :string) : [prefixLen int, cleaned string]
//
const cleanGlobPath = (
WIN32 ? (path, volumeNameLen) => { // (prefixLen int, cleaned string)
let vollen = volumeNameLen(path);
WIN32 ? (path, vollen) => { // (prefixLen int, cleaned string)
if (path == '') {
return [0, '.'];
}
Expand All @@ -81,15 +80,15 @@ const cleanGlobPath = (
vollen = path.length - 1;
}
return [vollen, path.substr(0, path.length-1)]; // chop off trailing separator
} : (path, volumeNameLen) => {
} : (path, vollen) => {
if (path == '') {
return [volumeNameLen, '.'];
return [vollen, '.'];
}
if (path == DIRSEP) {
// do nothing to the path
return [volumeNameLen, path];
return [vollen, path];
}
return [volumeNameLen, path.substr(0, path.length-1)]; // chop off trailing separator
return [vollen, path.substr(0, path.length-1)]; // chop off trailing separator
}
);

Expand Down