Don't request the contextualIdentities permission in Firefox builds - #549
Closed
Nawid3333 wants to merge 1 commit into
Closed
Don't request the contextualIdentities permission in Firefox builds#549Nawid3333 wants to merge 1 commit into
Nawid3333 wants to merge 1 commit into
Conversation
Firefox scopes that permission to the browser.contextualIdentities namespace - querying and editing container definitions - which nothing in the project calls. The container support in background.mjs's DOWNLOAD handler only reads sender.tab.cookieStoreId and passes it to tabs.create(), and cookieStoreId is gated on "cookies", which is still requested. Verified: build_firefox_libre's manifest still requests storage, tabs, webRequest, declarativeNetRequest, downloads and cookies, so container downloads are unaffected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Nawid3333
added a commit
to Nawid3333/FastStream
that referenced
this pull request
Sep 7, 2026
…point Phase 10 is no longer "not started": Andrews54757#548, Andrews54757#549, Andrews54757#550 and Andrews54757#551 are open upstream, with follow-up comments on Andrews54757#547 and Andrews54757#546. The unlisted AMO submission pipeline ran end to end on 2026-09-07 (local sign plus the publish-amo workflow). The baseline re-capture is also recorded as done - the workspace-level baseline now holds the modernised fork at cd728ab (852 files, spot-verified), with the original V1.3.77 upstream build archived separately.
Owner
|
contextualIdentities was added in prior attempt to fix bug where downloads failed in specific firefox containers. Unfortunately firefox did not expose a mechanism for extensions to know about or control certain partitions so the permission currently does nothing. It will be important in the future once https://bugzilla.mozilla.org/show_bug.cgi?id=1917842 is solved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.mjsrequestscontextualIdentitiesin both Firefox targets, but nothing in the project callsbrowser.contextualIdentities.*. Firefox scopes that permission to exactly that namespace — querying and editing container definitions — so it's dead weight.The container support in
background.mjs'sDOWNLOADhandler only readssender.tab.cookieStoreIdand passes it totabs.create(), andcookieStoreIdis gated on"cookies", which this still requests.Why it's worth doing
Fewer permissions means a smaller install prompt and one less thing for a store reviewer to ask about.
A warning worth recording
cookiesmust stay. I very nearly removed it too, on the strength of a grep for.cookies.that found nothing — butcookieStoreIddoesn't match that pattern, and Mozilla's own schema is explicit:Dropping
cookiessilently breaks container downloads while leaving every test green. Flagging it in case anyone else runs the same grep and reaches the same wrong conclusion.Test plan
node build.mjsbuilds successfullyfirefox-libremanifest still requestsstorage, tabs, webRequest, declarativeNetRequest, downloads, cookies— container downloads unaffectedbrowser.contextualIdentitiescall site anywhere in the repo🤖 Generated with Claude Code