Skip to content

Don't request the contextualIdentities permission in Firefox builds #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nawid3333 wants to merge 1 commit into from
Closed

Don't request the contextualIdentities permission in Firefox builds #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,11 @@ async function buildFirefoxLibre() {
const manifestPath = path.join(firefoxLibreBuildDir, 'manifest.json');
const manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));

manifest.permissions.push('downloads', 'cookies', 'contextualIdentities');
// 'contextualIdentities' is not requested: Firefox scopes that permission
// to the browser.contextualIdentities namespace, which nothing here calls.
// The container support in background.mjs only reads a tab's
// cookieStoreId and passes it to tabs.create(), which 'cookies' covers.
manifest.permissions.push('downloads', 'cookies');

// remove the userscripts permission
manifest.permissions = manifest.permissions.filter((permission) => permission !== 'userScripts');
Expand Down Expand Up @@ -371,7 +375,8 @@ async function buildFirefoxDist() {
type: 'module',
};

manifest.permissions.push('downloads', 'cookies', 'contextualIdentities');
// see the matching comment in buildFirefoxLibre()
manifest.permissions.push('downloads', 'cookies');

// remove the userscripts permission
manifest.permissions = manifest.permissions.filter((permission) => permission !== 'userScripts');
Expand Down