Skip to content

No Input/output port order anymore in writeTreeNodesModelXML ? #851

Open

Description

@RhysMcK

Hi,

I notice in this commit d5ea17b you removed the input/output port ordering logic. As a result, when using writeTreeNodesModelXML() to auto-generate the <TreeNodesModel> tags for Groot2, the ports are in some ?random? order. This is than obviously reflected in Groot2 and not ideal. What was the rational behind removing this?

image

Thanks very much!

Activity

  1. facontidavide commented on Sep 21, 2024

    @facontidavide
    Collaborator

    The correct solution, in my opinion, is to presere the order of the ports as it was described in providedPorts.

    Unfortunately, this means that we need to apply a change that breaks the API / ABI.

    In the meantimes, can you test the changes here: #870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions