Repository navigation
Fix Reactive Sequence async control node validation - #1183
Merged
facontidavide merged 4 commits intoOct 24, 2026
Merged
facontidavide merged 4 commits into
facontidavide merged 4 commits into
Conversation
Async ACTION children are not detected by this check (the manifest does not record whether an action is asynchronous); that is tracked by BehaviorTree#1184, which should carry its own test, rather than a disabled one here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Thanks @vivoeiva, good catch: two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also verify XML against
AsyncFallback(not justAsyncSequence) underReactiveSequence. Remove unreacheable cases with action nodes. Tests added for these cases, including one disabled (failing) test that needs further rework to catch async action nodes underReactiveSequence.