Repository navigation
Include emscripten/fiber.h at global scope before minicoro.h - #1256
Merged
Merged
Conversation
minicoro.h includes <emscripten/fiber.h> from inside its own extern "C" block when building for Emscripten. That pulls Emscripten's C++ headers (e.g. em_asm.h with its template specializations) in with C linkage, and the build fails with "explicit specialization of undeclared template struct '__em_asm_sig'". Include <emscripten/fiber.h> in action_node.cpp, the only translation unit that includes minicoro.h, before minicoro.h. The include guard then prevents the second inclusion under extern "C". The vendored minicoro.h is left untouched. Fixes #1226 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1226.
minicoro.h(withMINICORO_IMPL) includes<emscripten/fiber.h>inside its ownextern "C"block when building with Emscripten, and that breaks the build ofsrc/action_node.cpp. This includes<emscripten/fiber.h>first, at global scope, so its include guard makes minicoro's nested include a no-op. There is no change on other platforms.🤖 Generated with Claude Code