Skip to content

Add _onStart precondition for script execution and fix CI error - #932

Closed
Aglargil wants to merge 3 commits into
BehaviorTree:masterfrom
Aglargil:master
Closed

Add _onStart precondition for script execution and fix CI error#932
Aglargil wants to merge 3 commits into
BehaviorTree:masterfrom
Aglargil:master

Conversation

@Aglargil

@Aglargil Aglargil commented Feb 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

#895

  1. feat: add _onStart precondition for script execution
  2. fix covert_impl checkTruncation for CI error

@Aglargil
feat: add _onStart precondition for script execution
345d793 
Add a new precondition type _onStart that allows executing scripts
before a node starts its tick. This provides symmetry with the
existing _post functionality.
@Aglargil
fix: covert_impl checkTruncation
d8ca1f1
@Aglargil

Aglargil commented Feb 11, 2025

Copy link
Copy Markdown
Contributor Author

Hi, @facontidavide
I've implemented the fixes in the PR, including adding the _onStart precondition and resolving the CI error in covert_impl checkTruncation. If you'd prefer a separate PR for just the CI fix, feel free to let me know—I'm happy to adjust!

This was referenced Feb 18, 2025
Closed
Closed
@facontidavide

facontidavide commented Feb 25, 2025

Copy link
Copy Markdown
Collaborator

@Aglargil I do want to include this, but I can not until I add this precondition to Groot2. Be patient :)

@facontidavide facontidavide self-assigned this Feb 25, 2025
@facontidavide facontidavide added the enhancement New feature or request label Feb 25, 2025
@Aglargil

Aglargil commented Feb 25, 2025

Copy link
Copy Markdown
Contributor Author

@Aglargil I do want to include this, but I can not until I add this precondition to Groot2. Be patient :)

Okay, looking forward to your updates!

@cktii cktii mentioned this pull request Feb 25, 2025
Merged
@facontidavide facontidavide mentioned this pull request Oct 25, 2026
Open
@facontidavide

facontidavide commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

Thanks @Aglargil, and sorry for the long wait! Superseded by #1261, which adds _onStart (with you as co-author) together with _onlyIf. It follows your approach: ON_START is the last precondition, so the script only runs if the node is actually going to tick. The checkTruncation CI fix is no longer needed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@facontidavide facontidavide

Labels

BT.CPP-5 enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aglargil @facontidavide