fix: drop redundant TextEncoder copy in SDK file writes - #41
Open
KIRA-L001 wants to merge 1 commit into
Open
Conversation
…racle-AI#36) Signed-off-by: KIRA-L001 <137947115+KIRA-L001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36.
writeFilesandwriteFileran string content throughnew TextEncoder().encode(...)beforeBuffer.from, allocating and copying the full content twice on the file-push hot path.Buffer.from(string)is already UTF-8 encoding andBuffer.from(Uint8Array)is the same copy the code already makes, so both call sites now pass thestring | Uint8Arrayunion straight toBuffer.from(...)— exactly the deletion proposed in the issue. Byte output is identical (Node utf8 and TextEncoder both substitute U+FFFD for lone surrogates).Verified locally in
packages/sdk:pnpm typecheck(strict) clean;pnpm test— 31 passed, including the existing multi-byte round-trip test ('hello 文件') that pins the encoding behaviour.