Skip to content

fix: drop redundant TextEncoder copy in SDK file writes #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KIRA-L001 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: drop redundant TextEncoder copy in SDK file writes #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions packages/sdk/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,11 +580,7 @@ export class Dormice {
name,
files: files.map((file) => ({
path: file.path,
contentBase64: Buffer.from(
typeof file.content === 'string'
? new TextEncoder().encode(file.content)
: file.content,
).toString('base64'),
contentBase64: Buffer.from(file.content).toString('base64'),
})),
});
return writeFilesResponseSchema.parse(data);
Expand All @@ -602,11 +598,7 @@ export class Dormice {
const data = await this.rpc('writeFile', {
name,
path,
contentBase64: Buffer.from(
typeof content === 'string'
? new TextEncoder().encode(content)
: content,
).toString('base64'),
contentBase64: Buffer.from(content).toString('base64'),
});
return writeFileResponseSchema.parse(data);
}
Expand Down