Skip to content

Resolve infinite loop when removing a datasource from the realtime data synchronizer#49

Open
philip-khaisman wants to merge 1 commit into
masterfrom
remove-data-synchronizer-infinite-loop
Open

Resolve infinite loop when removing a datasource from the realtime data synchronizer#49
philip-khaisman wants to merge 1 commit into
masterfrom
remove-data-synchronizer-infinite-loop

Conversation

@philip-khaisman

@philip-khaisman philip-khaisman commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

The TimeSeriesRealtimeDatasource.removeDataSynchronizer method was calling DataSynchronizerRealtime.removeDataSource method which then called TimeSeriesRealtimeDatasource.removeDataSynchronizer which then called the DataSynchronizerRealtime.removeDataSource method...ok you get the picture.

This bug was called out in the TimeSeriesReplayDatasource class so removed the offending cal as was done there.

Test

  • I verified the fix with the webtak plugin when i refactored realtime mode to use the data synchronizer but i later learned that we weren't using the data synchronizer on purpose. So testing this now will be annoying. I think it's an obvious enough change to review logically with the knowledge that it did work as expected when i was using the data synchronizer in realtime mode

@philip-khaisman philip-khaisman marked this pull request as ready for review June 19, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix infinite loop when removing data source from real time data synchronizer

1 participant