Skip to content

Resolve infinite loop when removing a datasource from the realtime data synchronizer #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philip-khaisman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolve infinite loop when removing a datasource from the realtime data synchronizer #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions source/core/datasource/TimeSeries.realtime.datasource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,6 @@ class TimeSeriesRealtimeDatasource extends DataSource {
}

async removeDataSynchronizer() {
if(this.dataSynchronizer) {
await this.dataSynchronizer.removeDataSource(this);
}
this.dataSynchronizer = undefined;
// remove datasynchronizer
// restore datasource topic
Expand Down
4 changes: 0 additions & 4 deletions source/core/datasource/TimeSeries.replay.datasource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,6 @@ class TimeSeriesReplayDatasource extends DataSource {
}

async removeDataSynchronizer() {
// ISSUE: this causing loop because this.dataSynchronizer.removeDataSource(this); is calling this method
// if(this.dataSynchronizer) {
// await this.dataSynchronizer.removeDataSource(this);
// }
this.init = undefined;
this.dataSynchronizer = undefined;
return this.checkInit();
Expand Down