Skip to content

Respect Clip availability during video playback - #8094

Open
3mdistal wants to merge 1 commit into
t3/clips-comment-access-hardeningfrom
t3/clips-video-takedown-hardening
Open

3mdistal wants to merge 1 commit into
t3/clips-comment-access-hardeningfrom
t3/clips-video-takedown-hardening

Conversation

@3mdistal

@3mdistal 3mdistal commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

This change landed through the standalone main-based PR #8291, merge 74b6ceb8fd101befe63c342a98fea40b7112a29e. This older stacked PR remains open until its diff is empty after the base is integrated; it must not land separately.

Video playback now respects the parent Clip's availability when serving attached earlier-screen-time footage. The existing restriction on the footage itself remains in place, including for owners and administrators.

Adds route-level regression coverage and a neutral Clips changelog entry. Based on #8092; this change is independent of the password-write PR.

Validation:

  • Five parent-availability cases failed on unchanged production source before the fix; all 41 video-route tests pass after it.
  • All 160 tests across the six relevant video, thumbnail, public-recording, and access suites pass.
  • Clips typecheck, formatting, LF/diff checks, and all 93 repository guards pass.
  • Independent technical review found no actionable issues.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Code Review Summary

PR #8094 updates the Clips video-serving route so attached footage is unavailable when either the parent Clip or the footage itself is marked taken_down. The route returns the existing 404 response before reading application state or fetching media; footage-level restrictions continue to apply to all roles. The added route tests cover a taken-down parent for anonymous, viewer, editor, admin, and owner cases, plus taken-down footage under a healthy parent. A neutral Clips changelog entry records the behavior change.

Risk: High — this affects an availability/access boundary for serving video. The change is narrowly scoped and consistent with the route's existing handling of parent-level Clip gates. Two independent code-review passes found no confirmed bugs, security issues, or performance problems. The tests exercise the bypassed parent takedown case across roles and preserve coverage for the existing footage-level rule.

Findings

No actionable findings.

🧪 Browser testing: Will run after this review (PR touches UI code)

@github-actions

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants