Repository navigation
Respect Clip availability during video playback - #8291
Conversation
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Review summary
PR #8291 updates the Clips video route so takedown availability is checked on both the gate Clip and the resolved footage row before app-state access or media retrieval. It adds regression cases for a taken-down parent Clip across anonymous, viewer, editor, admin, and owner roles, and for taken-down footage beneath a healthy Clip; the changelog entry records the behavior fix.
Risk: High because this route controls access to media, and the change intentionally overrides playback even for privileged roles. The implementation is appropriately placed before state and storage reads, and the tests assert both the 404 response and absence of those reads/fetches. Two independent code-review passes found no actionable defects in the PR diff. No inline comments are warranted.
🧪 Browser testing: Skipped — browser-test-planner is not available in this environment. The dev server was running, but visual verification could not be orchestrated here.
|
Here's a visual recap of what changed: Open the full interactive recap |

Attached footage could remain playable after its parent Clip was taken down: the video route replaced the Clip row with the footage row before checking availability. This change returns 404 when either row is taken down, including for owners and administrators, before reading or fetching media.
This is the standalone main-based version of #8094, as requested. It changes only the video route, its regression tests, and a Clips changelog entry.
Validation:
All hosted checks are complete without failures, and Steve approved this standalone PR. A final exact-head rerun passed all 41 video-route tests; the prospective merge into current main is clean and changes only the intended three paths. No live takedown or beta claim is made by these route tests.