Skip to content

Respect Clip availability during video playback - #8291

Merged
3mdistal merged 2 commits into
mainfrom
3mdistal/changes-5752
Oct 27, 2026
Merged

3mdistal merged 2 commits into
mainfrom
3mdistal/changes-5752

Conversation

@3mdistal

@3mdistal 3mdistal commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Attached footage could remain playable after its parent Clip was taken down: the video route replaced the Clip row with the footage row before checking availability. This change returns 404 when either row is taken down, including for owners and administrators, before reading or fetching media.

This is the standalone main-based version of #8094, as requested. It changes only the video route, its regression tests, and a Clips changelog entry.

Validation:

  • On current main production code, five parent-takedown cases failed while 36 controls passed; all 200 tests across six video/access suites pass with the fix.
  • Clips typecheck and formatting pass. The full guard run's two strict-lint findings are repaired and its affected guards pass; the compiler guard passes using the same compiler through a Windows-compatible launcher.
  • The original independent technical review found no actionable findings. The production change applies cleanly to main; tests were rerun here.

All hosted checks are complete without failures, and Steve approved this standalone PR. A final exact-head rerun passed all 41 video-route tests; the prospective merge into current main is clean and changes only the intended three paths. No live takedown or beta claim is made by these route tests.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Review summary

PR #8291 updates the Clips video route so takedown availability is checked on both the gate Clip and the resolved footage row before app-state access or media retrieval. It adds regression cases for a taken-down parent Clip across anonymous, viewer, editor, admin, and owner roles, and for taken-down footage beneath a healthy Clip; the changelog entry records the behavior fix.

Risk: High because this route controls access to media, and the change intentionally overrides playback even for privileged roles. The implementation is appropriately placed before state and storage reads, and the tests assert both the 404 response and absence of those reads/fetches. Two independent code-review passes found no actionable defects in the PR diff. No inline comments are warranted.

🧪 Browser testing: Skipped — browser-test-planner is not available in this environment. The dev server was running, but visual verification could not be orchestrated here.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

@3mdistal
3mdistal merged commit 74b6ceb into main Oct 27, 2026
49 checks passed
@3mdistal
3mdistal deleted the 3mdistal/changes-5752 branch October 27, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants