Skip to content

docs: mirror workspace ADR-016 and ADR-020 (op-layer seams) - #166

Merged
benceruleanlu merged 1 commit into
mainfrom
christian-byrne/docc2-adr-016-020-mirror
Sep 2, 2026
Merged

docs: mirror workspace ADR-016 and ADR-020 (op-layer seams)#166
benceruleanlu merged 1 commit into
mainfrom
christian-byrne/docc2-adr-016-020-mirror

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Mirrors two workspace-level ADRs into this repo per decisions/AGENTS.md in the
in-app-agent-program workspace, which states that op-layer decisions must be committed
into comfy-multi-player (not left only in the cross-repo workspace) so a low-context
dev on this repo can see them. Follows the same pattern already used for ADR-021
(docs/decisions/ADR-021-doc-derived-lamport-clock-store.md).

  • ADR-016: namespace widget LWW stamps by node incarnation (DQ-11).
  • ADR-020: Lamport vs vector clocks vs base_version for graph ordering.

Content copied verbatim, no edits. Numbering kept at the workspace ADR number (matching
the ADR-021 precedent) rather than renumbered into this repo's local ADR-001..008 series.

Evidence

$ diff docs/decisions/ADR-016-dq11-incarnation-namespaced-stamps.md ~/workspaces/in-app-agent/decisions/ADR-016-dq11-incarnation-namespaced-stamps.md
(no output — byte-identical)

$ diff docs/decisions/ADR-020-lamport-vs-vector-vs-base-version.md ~/workspaces/in-app-agent/decisions/ADR-020-lamport-vs-vector-vs-base-version.md
(no output — byte-identical)

Copies decisions/ADR-016-dq11-incarnation-namespaced-stamps.md and
decisions/ADR-020-lamport-vs-vector-vs-base-version.md verbatim from the
in-app-agent-program workspace into this repo per decisions/AGENTS.md
(comfy-multi-player governs the op layer). No content changes.

Workspace source: christian-byrne/in-app-agent-program decisions/AGENTS.md
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 115 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: db8bce5a-f0f4-4c8e-a4b8-9d34179f0317

📥 Commits

Reviewing files that changed from the base of the PR and between 26a2736 and 981785d.

📒 Files selected for processing (2)
  • docs/decisions/ADR-016-dq11-incarnation-namespaced-stamps.md
  • docs/decisions/ADR-020-lamport-vs-vector-vs-base-version.md

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R1 exact-head review at 981785de. Two lenses: implementation correctness, workspace/doc context.

Full context for agent readers

Tier: R1 (docs-only, 315 additions, 2 new ADR files)

Lens 1 — implementation correctness (doc content):

  • Both ADRs are well-structured with status, date, decider, context, decision, alternatives, consequences, references, and glossary.
  • ADR-016 status accepted, DQ-11 option (c) — consistent with workspace decision-queue.
  • ADR-020 status Proposed with shadow-comparison verification gate — deadline 2026-09-02 (today).
  • ADR-020 decision matrix is thorough; rollback-safety checks and shadow-comparison validation plan are well-specified.

Lens 2 — workspace/doc context:

  • PR follows the established ADR mirror pattern (same as ADR-021). PR body references decisions/AGENTS.md which states op-layer decisions must be committed into cmp.
  • CI green, mergeable, no reviews yet.

Findings:

  1. (nit) ADR-020 references ../reports/spikes/dq10-lamport-feasibility.md and ../AGENTS.md — these are workspace-relative paths that won't resolve from the cmp repo's docs/decisions/ directory. The prior ADR-021 mirror is self-contained. Consider noting these as workspace paths or rewriting to URLs.

  2. (nit) ADR-016 references program/decision-queue.md, program/dq-11-primer.md, reports/spikes/spike-5-merge-suite.md — same workspace-relative path issue. The cmp-relative references (docs/multiplayer-schema.md, docs/INVARIANTS.md) resolve correctly.

  3. (observation) ADR-020's shadow-comparison deadline is 2026-09-02 (today). The ADR remains Proposed until that verification completes. If the shadow-comparison lane has results, the status should be updated.

No blocking findings. Documents are substantive and well-reasoned.

@benceruleanlu benceruleanlu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 981785de; no blocking findings.

Non-blocking findings
  • docs/decisions/ADR-016-dq11-incarnation-namespaced-stamps.md cites schema Amendment A15 for DQ-11; the enacted incarnation namespace is Amendment A16 (KA-4, KA-11).
  • Several mirrored workspace-relative references do not resolve in this repository, including the ADR-007, report, and AGENTS links in ADR-020 and the program/report paths in ADR-016. A mirror note or accessible source links would help low-context readers.
  • ADR-020 preserves historical Proposed text even though ADR-021 now supersedes and narrows it. A short mirror note would make the current decision state clearer (KA-2, FC-2, FC-9).

@benceruleanlu
benceruleanlu merged commit e89b430 into main Sep 2, 2026
7 checks passed
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Follow-up PR opened: #174 — addresses all three non-blocking findings from the review here (A15→A16 amendment cite, workspace-relative links → deep links + mirror note, ADR-020 supersession note vs ADR-021). Assigned to @benceruleanlu for visibility.

Full context for agent readers
  • Source row: todo act-cmp-166-followup (awc-audit follow-up; second-pass verifier CONFIRMED_GAP — no follow-up PR existed).
  • Findings addressed from the APPROVED review (id 5095287625, head 981785de):
    1. ADR-016 cited schema Amendment A15 for DQ-11; the enacted incarnation namespace is Amendment A16 (KA-4, KA-11).
    2. Mirrored workspace-relative references do not resolve in this repo (ADR-007, report, AGENTS links in ADR-020; program/report paths in ADR-016).
    3. ADR-020 preserves historical Proposed text though ADR-021 supersedes and narrows it.
  • Change verified against main pre-PR (stale findings confirmed live) and all rewritten links point at paths that exist on the workspace repo's main.
  • Docs-only, labeled risk:R1, assignee benceruleanlu per the row spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R1 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants