docs: mirror workspace ADR-016 and ADR-020 (op-layer seams) - #166
Conversation
Copies decisions/ADR-016-dq11-incarnation-namespaced-stamps.md and decisions/ADR-020-lamport-vs-vector-vs-base-version.md verbatim from the in-app-agent-program workspace into this repo per decisions/AGENTS.md (comfy-multi-player governs the op layer). No content changes. Workspace source: christian-byrne/in-app-agent-program decisions/AGENTS.md
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 115 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
R1 exact-head review at 981785de. Two lenses: implementation correctness, workspace/doc context.
Full context for agent readers
Tier: R1 (docs-only, 315 additions, 2 new ADR files)
Lens 1 — implementation correctness (doc content):
- Both ADRs are well-structured with status, date, decider, context, decision, alternatives, consequences, references, and glossary.
- ADR-016 status
accepted, DQ-11 option (c) — consistent with workspace decision-queue. - ADR-020 status
Proposedwith shadow-comparison verification gate — deadline 2026-09-02 (today). - ADR-020 decision matrix is thorough; rollback-safety checks and shadow-comparison validation plan are well-specified.
Lens 2 — workspace/doc context:
- PR follows the established ADR mirror pattern (same as ADR-021). PR body references
decisions/AGENTS.mdwhich states op-layer decisions must be committed into cmp. - CI green, mergeable, no reviews yet.
Findings:
-
(nit) ADR-020 references
../reports/spikes/dq10-lamport-feasibility.mdand../AGENTS.md— these are workspace-relative paths that won't resolve from the cmp repo'sdocs/decisions/directory. The prior ADR-021 mirror is self-contained. Consider noting these as workspace paths or rewriting to URLs. -
(nit) ADR-016 references
program/decision-queue.md,program/dq-11-primer.md,reports/spikes/spike-5-merge-suite.md— same workspace-relative path issue. The cmp-relative references (docs/multiplayer-schema.md,docs/INVARIANTS.md) resolve correctly. -
(observation) ADR-020's shadow-comparison deadline is 2026-09-02 (today). The ADR remains
Proposeduntil that verification completes. If the shadow-comparison lane has results, the status should be updated.
No blocking findings. Documents are substantive and well-reasoned.
benceruleanlu
left a comment
There was a problem hiding this comment.
Reviewed exact head 981785de; no blocking findings.
Non-blocking findings
docs/decisions/ADR-016-dq11-incarnation-namespaced-stamps.mdcites schema Amendment A15 for DQ-11; the enacted incarnation namespace is Amendment A16 (KA-4, KA-11).- Several mirrored workspace-relative references do not resolve in this repository, including the ADR-007, report, and AGENTS links in ADR-020 and the program/report paths in ADR-016. A mirror note or accessible source links would help low-context readers.
- ADR-020 preserves historical
Proposedtext even though ADR-021 now supersedes and narrows it. A short mirror note would make the current decision state clearer (KA-2, FC-2, FC-9).
|
Follow-up PR opened: #174 — addresses all three non-blocking findings from the review here (A15→A16 amendment cite, workspace-relative links → deep links + mirror note, ADR-020 supersession note vs ADR-021). Assigned to @benceruleanlu for visibility. Full context for agent readers
|
Summary
Mirrors two workspace-level ADRs into this repo per
decisions/AGENTS.mdin thein-app-agent-program workspace, which states that op-layer decisions must be committed
into
comfy-multi-player(not left only in the cross-repo workspace) so a low-contextdev on this repo can see them. Follows the same pattern already used for ADR-021
(
docs/decisions/ADR-021-doc-derived-lamport-clock-store.md).ADR-016: namespace widget LWW stamps by node incarnation (DQ-11).ADR-020: Lamport vs vector clocks vsbase_versionfor graph ordering.Content copied verbatim, no edits. Numbering kept at the workspace ADR number (matching
the ADR-021 precedent) rather than renumbered into this repo's local ADR-001..008 series.
Evidence
$ diff docs/decisions/ADR-016-dq11-incarnation-namespaced-stamps.md ~/workspaces/in-app-agent/decisions/ADR-016-dq11-incarnation-namespaced-stamps.md
(no output — byte-identical)
$ diff docs/decisions/ADR-020-lamport-vs-vector-vs-base-version.md ~/workspaces/in-app-agent/decisions/ADR-020-lamport-vs-vector-vs-base-version.md
(no output — byte-identical)