docs: address #166 review findings on ADR-016/020 mirror - #174
Open
christian-byrne wants to merge 1 commit into
Open
docs: address #166 review findings on ADR-016/020 mirror#174christian-byrne wants to merge 1 commit into
christian-byrne wants to merge 1 commit into
Conversation
- ADR-016: cite schema Amendment A16 (DQ-11 incarnation-namespaced widget stamps) instead of A15, which governs promoted subgraph host writes. - ADR-016/020: replace workspace-relative paths that do not resolve in this repository with deep links to christian-byrne/in-app-agent-program and add a mirror note explaining the workspace path convention. - ADR-020: add a supersession mirror note pointing to the accepted ADR-021 (narrows this ADR) while preserving the historical Proposed record. Follow-up to #166 (approve-with-comments review by @benceruleanlu).
christian-byrne
added
documentation
christian-byrne
added
documentation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 128 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only follow-up addressing every non-blocking finding in the approve-with-comments review on #166 (review id 5095287625, @benceruleanlu, head
981785de).Changes
docs/multiplayer-schema.mdAmendment A15 for DQ-11; the enacted incarnation-namespaced widget stamps amendment is A16 (A15 governs promoted subgraph host writes). Now cites A16 with a deep link and a one-line disambiguation.program/decision-queue.md,program/dq-11-primer.md,reports/spikes/spike-5-merge-suite.md, plus the inline spike/conflict-matrix paths) and ADR-020 (ADR-007-op-based-crdt-v1.md— which does not exist in this repo and shadowed the cmp ADR-007,../reports/spikes/dq10-lamport-feasibility.md,../AGENTS.md) now link to the source paths inchristian-byrne/in-app-agent-program, and both ADRs carry a mirror note stating thatprogram/…andreports/…paths are workspace-repo paths.Proposedstatus and verification gate as record; current decision state is ADR-021 with KA-2, FC-2, FC-9.Evidence
mainbefore this PR: ADR-016 still cited "Amendment A15" (schema## Amendment A16 — 2026-08-28 — DQ-11 incarnation-namespaced widget stampsis the enacted one);grep '](\.\./'over both ADRs returned hits pre-change, zero post-change; ADR-020 Status line unchanged since docs: mirror workspace ADR-016 and ADR-020 (op-layer seams) #166 with no ADR-021 cross-reference.main(git ls-tree origin/main).](../links, no remaining bare "Amendment A15" citation in ADR-016.