Repository navigation
fix(dialogs): dashboard settings and versions open in the board dialog frame - #855
Merged
Merged
Conversation
…g frame
720px wide, the dashboard's name as a small line over a 20px title, as
boards LpDashboardInstellingen and LpVersies draw them. Version history is
titled "Versions of {name}" when the name is known.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 13, 2026 13:33
…ard-frame # Conflicts: # l10n/nl.js # l10n/nl.json
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 1953/1953 | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-13 13:46 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard settings dialog and version history now open in the board dialog frame (LpDashboardInstellingen, LpVersies).
What changed
Views.vuepasses the active dashboard's name.src/styles/modals.cssunderlaunchpad-modal--wide, so the other modals do not change.h2size andpweight with!important. The two frame lines answer with!importantand win on specificity; the stylesheet says why.nl.jsonandnl.jsonly (adding it toen.jsonwould make the parity check demand it in every language).No component added. Nothing removed: every tab, field and button stays where it was.
Verified (local)
npm run lint: exit 0.stylelint: exit 0. l10n parity: exit 0.npx vitest run --maxWorkers=2: exit 1, 962 of 962 tests pass, 120 of 121 files;tests/vitest/shared-instance.spec.tsfails to load (@vue/tsconfigabove the mount, same on development). Two new tests pin the kicker and the "Versions of" title.npm run build: exit 0. No PHP changed.LA/diffs-10/.Left open