Skip to content

fix(dialogs): dashboard settings and versions open in the board dialog frame - #855

Merged
rubenvdlinde merged 3 commits into
developmentfrom
fix/dialogs-board-frame
Oct 13, 2026
Merged

rubenvdlinde merged 3 commits into
developmentfrom
fix/dialogs-board-frame

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

The dashboard settings dialog and version history now open in the board dialog frame (LpDashboardInstellingen, LpVersies).

What changed

  • Both dialogs are 720px wide instead of NcModal's 600px.
  • Over the title sits the dashboard's name as a small grey line; the title is 20px bold. Version history is titled "Versies van {name}" when the name is known, as the board writes it, and keeps "Versiegeschiedenis" otherwise. Views.vue passes the active dashboard's name.
  • Version history gets the 24px padding the other dialogs have.
  • All of it sits in src/styles/modals.css under launchpad-modal--wide, so the other modals do not change.
  • The house style (thematiq) sets h2 size and p weight with !important. The two frame lines answer with !important and win on specificity; the stylesheet says why.
  • New string "Versions of {name}" in nl.json and nl.js only (adding it to en.json would make the parity check demand it in every language).

No component added. Nothing removed: every tab, field and button stays where it was.

Verified (local)

  • npm run lint: exit 0. stylelint: exit 0. l10n parity: exit 0.
  • npx vitest run --maxWorkers=2: exit 1, 962 of 962 tests pass, 120 of 121 files; tests/vitest/shared-instance.spec.ts fails to load (@vue/tsconfig above the mount, same on development). Two new tests pin the kicker and the "Versions of" title.
  • npm run build: exit 0. No PHP changed.
  • Pixel diff as pieter (dialogs opened from the dashboard cog):
    • LpDashboardInstellingen: 53.47% before, 47.12% after (header region 47.62% to 39.61%, content 40.35% to 32.05%).
    • LpVersies: 72.27% before, 70.58% after (content 58.42% to 55.31%).
    • Screenshots: LA/diffs-10/.

Left open

  • LpDashboardInstellingen: the board has three tabs (Details, Talen, Delen with a count); the dialog has five (Algemeen, Delen, Standaard, Talen, Details). Folding Algemeen and Standaard into Details is the next step. The board's Thema, Taal van dit dashboard and Bewaartermijn fields have no backend.
  • LpVersies: the board draws a filterable table with a preview card. Here the dashboard has no saved versions, so the table cannot show.
  • The title reads English until fix(l10n): Dutch for the 253 strings that had none #853 (Dutch strings) is merged.

…g frame

720px wide, the dashboard's name as a small line over a 20px title, as
boards LpDashboardInstellingen and LpVersies draw them. Version history is
titled "Versions of {name}" when the name is known.
…ard-frame

# Conflicts:
#	l10n/nl.js
#	l10n/nl.json
@rubenvdlinde
rubenvdlinde merged commit b08bc5c into development Oct 13, 2026
32 of 34 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ db384ce

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ✅
composer ✅ ✅ 107/107
npm ✅ ✅ 636/636
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ✅ 1953/1953
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-13 13:46 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant