Repository navigation
fix(styles): launchpad loads the library stylesheet itself - #861
Merged
Merged
Conversation
main.js, public.js and admin.js never imported @conduction/nextcloud-vue/css/index.css. The board look, widget and dialog styles only arrived when another app's bundle on the page carried them, which is why the Flows toolbar centred its buttons. pipelinq, dossiq and shillinq import it the same way.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 1953/1953 | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-13 17:48 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added a commit
that referenced
this pull request
Oct 13, 2026
The library stylesheet check holds on the new dist: cn-store-page is in the CSS and library-style.js stamps data-cn-library. No app workaround needed removing; the app already imports the library stylesheet (#861).
rubenvdlinde
added a commit
that referenced
this pull request
Oct 14, 2026
…ok, opening on Algemeen (#862) * fix(admin): the admin page opens on Algemeen, in the board's cards and tabs The setup banner, the defaults, group-shared dashboards and the default-app note sat above the tab strip on every tab. They now form the first tab, Algemeen, as cards in two columns (board LpBeheerAlgemeen), and the page opens there. The tab strip takes the board's 44px tabs with a 3px underline, and four tab names follow the board: Bediening, Versies en analyse, Organisatiemenu, Demogegevens. * fix(admin): the admin page uses the full width, as the board * Revert "fix(admin): the admin page uses the full width, as the board" This reverts commit c0829bf. * chore(deps): launchpad builds on nextcloud-vue 2.82.0 The library stylesheet check holds on the new dist: cn-store-page is in the CSS and library-style.js stamps data-cn-library. No app workaround needed removing; the app already imports the library stylesheet (#861). * fix(admin): the admin page draws in the library admin shell, board look CnAdminSettingsShell with look="board" draws the h1 that names the open tab, the path line (Beheerinstellingen / Launchpad / <tab>, with "geldt voor de hele organisatie" on Algemeen) and the Documentatie button. No version card: the board has none. The tab strip is a plain child of the shell, so it spans the grid without a card or heading. On Algemeen the defaults, group-shared dashboards and the default-app note are CnSettingsSection cards in the shell's two columns. The app's own card and grid CSS goes: the library draws both. l10n: two strings. nl carries the board's Dutch; the other required locales carry the English text. * fix(admin): switches as the board draws them, no strip under the banner The three on/off defaults are switches. The tab panel takes its tab's height and draws no white surface below the setup banner. The spec keeps the router's other exports and lint is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launchpad now loads the library stylesheet itself:
import '@conduction/nextcloud-vue/css/index.css'insrc/main.js,src/public.jsandsrc/admin.js, as pipelinq, dossiq and shillinq do.Until now the board look, widget and dialog styles of
@conduction/nextcloud-vuereached launchpad's pages only when another app's bundle on the same page happened to carry them. Found by lane L7: it is why the Flows toolbar centred its buttons.What changes for a user
Compared on :8080 as pieter, same build otherwise (before:
LA/shots-14b/,LA/diffs-14b/; after:LA/shots-14/,LA/diffs-14/):Nothing is removed.
Verified (local)
One heavy call: build and measure the entry files of development first, then the change.
npm run lint0,npm run build0. No style file changed, so stylelint had nothing to check. No PHP changed.npx vitest run --maxWorkers=2: exit 1, 965 of 965 tests pass, 121 of 122 files;tests/vitest/shared-instance.spec.tsfails to load (@vue/tsconfigabove the mount, same on development).Left open
CnStorePageheader under the board look leaves room left of the title. Library.src/kiosk.jsimports no library component, so it does not load the stylesheet.