Repository navigation
Fix the npm publish path; retry the staging tests after a pause - #107
Merged
Merged
Conversation
npm publish read out/convertapi-1.15.1.tgz as the GitHub shorthand out/convertapi-1.15.1.tgz, so v1.15.1 never reached npm; ./out/... is a file. The staging API answered 503 to four tests three times in a row, so the suite now gets up to three attempts 30 s apart on top of mocha's retries. CHANGELOG: the release is 1.15.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused workflow changes preserve success and failure outcomes, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Fixes npm tarball publishing and adds delayed retries to tolerate temporary staging API failures.
Changes:
- Uses an explicit
./out/...path for npm publishing. - Retries test suites up to three times, 30 seconds apart, and increases example retry delays.
- Updates the changelog to 1.15.2 and explains why 1.15.1 was not published.
| File | Description |
|---|---|
| CHANGELOG.md | Documents 1.15.2 and the failed 1.15.1 publish. |
| .github/workflows/publish.yml | Fixes the publish path and adds test-suite retries. |
| .github/workflows/build.yml | Adds test-suite retries and increases example retry delays. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm publish out/convertapi-1.15.1.tgzfailed: npm readsout/...as GitHub shorthand and triedgit ls-remote ssh://git@github.com/out/convertapi-1.15.1.tgz.git. Nothing was published. The workflow now passes./out/...; a localnpm publish ./out/convertapi-1.15.2.tgz --dry-runresolves the file.🤖 Generated with Claude Code