refactor(firmware): extract vehicle state estimator (LOS-166) - #309
Merged
Conversation
LostPointer
marked this pull request as ready for review
July 28, 2026 09:44
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a25bdb3e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Первый этап LOS-166: логика оценки состояния вынесена из
ControlLoopProcessorв отдельныйVehicleStateEstimatorбез изменения математики и внешних контрактов контура управления.Тип изменения
Что изменено
VehicleStateEstimatorи явные структуры входного/выходного снимка.ControlLoopProcessor; добавлены 7 unit-тестов и регистрация новых файлов в host/ESP32 CMake.ImuHandler, Madgwick и LOS-221 намеренно не изменялось.Как протестировано
sim_host.RC_PROFILE_LOOP=ON; тесты estimator прошли.git diff --check— без ошибок.Сборка ESP-IDF на целевую платформу не запускалась:
idf.pyнедоступен в окружении.clang-formatтакже отсутствует; новые файлы вручную проверены на длину строк.Чек-лист
Breaking Changes
Нет.
Производительность
На целевом оборудовании не измерялась. Граница profiler stage сохранена.
Связанные задачи
Related to LOS-166.
На что обратить внимание при ревью
VehicleStateEstimator.