Preserve deterministic sampler rates - #12382
Open
MilanGarnier wants to merge 3 commits into
Open
Conversation
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: 8e80184 | Docs | View more details | Give us feedback! |
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
MilanGarnier
marked this pull request as ready for review
September 2, 2026 13:19
MilanGarnier
requested review from
danyal002,
leoromanovsky and
mhlidd
and removed request for
a team
September 2, 2026 13:19
MilanGarnier
force-pushed
the
milan.garnier/preserve-deterministic-sampler-rate
branch
from
September 2, 2026 13:29
4cd94ee to
58c6dc5
Compare
mhlidd
approved these changes
Sep 2, 2026
mhlidd
left a comment
Contributor
There was a problem hiding this comment.
LGTM contingent on reverting ffe-system-test-data
Contributor
There was a problem hiding this comment.
❓ Is this file meant to be changed?
Contributor
|
Merged w/ master to pull in CI fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Preserves configured deterministic sampler rates at double precision.
Motivation
The sampler accepted a
doublebut retained afloat, sogetSampleRate()lost configured precision.
Additional Notes
Tested with
./gradlew :dd-trace-core:test --tests datadog.trace.common.sampling.DeterministicTraceSamplerTest --rerun-tasks.Contributor Checklist
comp: core,type: bug fix, andtag: ai generatedlabels.Jira ticket: N/A