Skip to content

Preserve deterministic sampler rates #12382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MilanGarnier wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −3
Open

Preserve deterministic sampler rates #12382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ecfed6
fix(sampling): preserve deterministic sampler rate
MilanGarnier Sep 2, 2026
58c6dc5
gradlew spotlessApply
MilanGarnier Sep 2, 2026
8e80184
Merge branch 'master' into milan.garnier/preserve-deterministic-sampl…
mhlidd Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data
Open in desktop

@mhlidd mhlidd Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Is this file meant to be changed?

Submodule ffe-system-test-data updated 21 files
+0 −210 .github/workflows/downstream-compatibility.yml
+0 −31 .github/workflows/validate-fixtures.yml
+5 −20 CONTRIBUTING.md
+7 −56 README.md
+0 −129 ci/run-downstream-conformance.sh
+0 −179 ci/validate-fixtures.py
+0 −59 evaluation-cases/test-case-invalid-condition-operands.json
+0 −17 evaluation-cases/test-case-invalid-regex-isolation.json
+4 −6 evaluation-cases/test-case-invalid-shard-bounds-isolation.json
+2 −3 evaluation-cases/test-case-malformed-flag-isolation.json
+2 −3 evaluation-cases/test-case-missing-split-shards-isolation.json
+0 −15 evaluation-cases/test-case-null-shard-range-isolation.json
+0 −39 evaluation-cases/test-case-regex-flag.json
+0 −120 evaluation-cases/test-case-semver-invalid-comparand-categories.json
+0 −17 evaluation-cases/test-case-semver-invalid-comparand-waterfall.json
+0 −170 evaluation-cases/test-case-semver-precedence-flag.json
+15 −142 evaluation-cases/test-case-semver-validation-flag.json
+0 −118 evaluation-cases/test-case-semver-version-parts.json
+2 −3 evaluation-cases/test-case-unknown-operator-isolation.json
+0 −27 evaluation-cases/test-case-variant-type-mismatch.json
+7 −1,270 ufc-config.json
4 changes: 2 additions & 2 deletions dd-trace-core/src/main/java/datadog/trace/common/sampling/DeterministicSampler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ protected <T extends CoreSpan<T>> long getSamplingId(T span) {

private static final double MAX = Math.pow(2, 64) - 1;

private final float rate;
private final double rate;
private final long threshold;

public DeterministicSampler(final double rate) {
this.rate = (float) rate;
this.rate = rate;
this.threshold = cutoff(rate);
}

Expand Down
5 changes: 5 additions & 0 deletions dd-trace-core/src/test/java/datadog/trace/common/sampling/DeterministicTraceSamplerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,11 @@ void testSamplingAll(String traceId) {
assertTrue(sampler.sample(span));
}

@TableTest({"rate ", "0.123456789", "0.999999999"})
void preservesConfiguredSampleRate(double rate) {
assertEquals(rate, new DeterministicSampler.TraceSampler(rate).getSampleRate());
}

@ParameterizedTest(name = "rate={0}")
@MethodSource("testCutoffCalculationArguments")
void testCutoffCalculation(int rate) {
Expand Down