Repository navigation
ci: retarget core profile contract after boot-properties extraction - #222
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5ded6177f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| contains services/core/src/main/java/com/ulticode/core/CoreOwnerBootProperties.java \ | ||
| 'CoreLocalContractAssembly.LOCAL_CONTRACTS_ENABLED_PROPERTY' |
There was a problem hiding this comment.
Verify the boot path still invokes the property builder
If CoreOwnerContextManager stops calling bootProperties.forModule(module)—for example, by passing an empty or independently built property list—all six retargeted checks still pass because the now-unused CoreOwnerBootProperties retains these literals. Before the extraction, checking the manager at least coupled the guarded properties to the child-context boot implementation; add an assertion for the bootProperties.forModule(module) invocation or a focused behavioral test so this contract cannot silently become dead code.
Useful? React with 👍 / 👎.
Fixes the three CI jobs failing on main (run 35896106913, also reproduced pre-merge on PR #221's run):
Root cause (single):
scripts/test/core-profile-contract.shasserted thatCoreOwnerContextManager.javacontainsCoreLocalContractAssembly.LOCAL_CONTRACTS_ENABLED_PROPERTYand five other boot-property strings. PR #221 delivered T9 (boot-properties factory extraction), which moved that property assembly intoCoreOwnerBootProperties.java—fail()exits at the first mismatch, so all three jobs running the static suite (Backend/Frontend contract, Docker Load Service Matrix) failed on the same line.Fix: retarget the six property-location assertions to
CoreOwnerBootProperties.java(the property's actual assembly source after the refactor). Manager-side assertions forCoreLocalContractAssembly.register(...)/validate(...)and the negativeregisterChildContractscheck remain unchanged. Guard intent preserved — still asserting the flag exists exactly where child-context properties are built.Verification:
bash scripts/test/core-profile-contract.sh→ PASS;./scripts/dev/test.sh static→ all checks passed (exit 0) locally on this branch.