Skip to content

ci: retarget core profile contract after boot-properties extraction - #222

Merged
DavidHLP merged 1 commit into
mainfrom
fix/ci-core-contract
Sep 24, 2026
Merged

DavidHLP merged 1 commit into
mainfrom
fix/ci-core-contract

Conversation

@DavidHLP

Copy link
Copy Markdown
Owner

Fixes the three CI jobs failing on main (run 35896106913, also reproduced pre-merge on PR #221's run):

Root cause (single): scripts/test/core-profile-contract.sh asserted that CoreOwnerContextManager.java contains CoreLocalContractAssembly.LOCAL_CONTRACTS_ENABLED_PROPERTY and five other boot-property strings. PR #221 delivered T9 (boot-properties factory extraction), which moved that property assembly into CoreOwnerBootProperties.java — fail() exits at the first mismatch, so all three jobs running the static suite (Backend/Frontend contract, Docker Load Service Matrix) failed on the same line.

Fix: retarget the six property-location assertions to CoreOwnerBootProperties.java (the property's actual assembly source after the refactor). Manager-side assertions for CoreLocalContractAssembly.register(...)/validate(...) and the negative registerChildContracts check remain unchanged. Guard intent preserved — still asserting the flag exists exactly where child-context properties are built.

Verification: bash scripts/test/core-profile-contract.sh → PASS; ./scripts/dev/test.sh static → all checks passed (exit 0) locally on this branch.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T01:49:47.644586Z a5ded61 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5ded6177f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +33 to 34
contains services/core/src/main/java/com/ulticode/core/CoreOwnerBootProperties.java \
'CoreLocalContractAssembly.LOCAL_CONTRACTS_ENABLED_PROPERTY'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Verify the boot path still invokes the property builder

If CoreOwnerContextManager stops calling bootProperties.forModule(module)—for example, by passing an empty or independently built property list—all six retargeted checks still pass because the now-unused CoreOwnerBootProperties retains these literals. Before the extraction, checking the manager at least coupled the guarded properties to the child-context boot implementation; add an assertion for the bootProperties.forModule(module) invocation or a focused behavioral test so this contract cannot silently become dead code.

Useful? React with 👍 / 👎.

@DavidHLP
DavidHLP merged commit b6826b6 into main Sep 24, 2026
14 checks passed
@DavidHLP
DavidHLP deleted the fix/ci-core-contract branch September 24, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant