Skip to content

ci: retarget core profile contract after boot-properties extraction #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidHLP merged 1 commit into from
Sep 24, 2026
Merged

ci: retarget core profile contract after boot-properties extraction #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions scripts/test/core-profile-contract.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ contains services/core/src/main/java/com/ulticode/core/CoreLocalContractAssembly
contains services/core/src/main/java/com/ulticode/core/CoreLocalContractAssembly.java 'static void validate('
contains services/core/src/main/java/com/ulticode/core/CoreLocalContractAssembly.java \
'LOCAL_CONTRACTS_ENABLED_PROPERTY'
contains services/core/src/main/java/com/ulticode/core/CoreOwnerContextManager.java \
contains services/core/src/main/java/com/ulticode/core/CoreOwnerBootProperties.java \
'CoreLocalContractAssembly.LOCAL_CONTRACTS_ENABLED_PROPERTY'
Comment on lines +33 to 34

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Verify the boot path still invokes the property builder

If CoreOwnerContextManager stops calling bootProperties.forModule(module)—for example, by passing an empty or independently built property list—all six retargeted checks still pass because the now-unused CoreOwnerBootProperties retains these literals. Before the extraction, checking the manager at least coupled the guarded properties to the child-context boot implementation; add an assertion for the bootProperties.forModule(module) invocation or a focused behavioral test so this contract cannot silently become dead code.

Useful? React with 👍 / 👎.

contains services/admin/src/main/java/com/ulticode/modules/admin/port/adapter/AdminDubboReferenceRegistry.java \
'@ConditionalOnProperty'
Expand Down Expand Up @@ -63,11 +63,11 @@ not_contains services/core/src/main/java/com/ulticode/core/CoreOwnerBootConfigur
not_contains services/core/src/main/java/com/ulticode/core/CoreOwnerBootConfigurations.java '"com.ulticode.modules.reconciliation",'
contains services/core/src/main/java/com/ulticode/core/CoreReadinessController.java '/api/v1/core/health'
contains services/core/src/main/java/com/ulticode/core/CoreSecurityConfiguration.java 'anyRequest().denyAll()'
contains services/core/src/main/java/com/ulticode/core/CoreOwnerContextManager.java 'spring.main.web-application-type=none'
contains services/core/src/main/java/com/ulticode/core/CoreOwnerContextManager.java 'core.datasource.'
contains services/core/src/main/java/com/ulticode/core/CoreOwnerContextManager.java 'dubbo.enabled=false'
contains services/core/src/main/java/com/ulticode/core/CoreOwnerContextManager.java 'security.internal-delegation.private-key='
contains services/core/src/main/java/com/ulticode/core/CoreOwnerContextManager.java 'INTERNAL_DELEGATION_PUBLIC_KEY'
contains services/core/src/main/java/com/ulticode/core/CoreOwnerBootProperties.java 'spring.main.web-application-type=none'
contains services/core/src/main/java/com/ulticode/core/CoreOwnerBootProperties.java 'core.datasource.'
contains services/core/src/main/java/com/ulticode/core/CoreOwnerBootProperties.java 'dubbo.enabled=false'
contains services/core/src/main/java/com/ulticode/core/CoreOwnerBootProperties.java 'security.internal-delegation.private-key='
contains services/core/src/main/java/com/ulticode/core/CoreOwnerBootProperties.java 'INTERNAL_DELEGATION_PUBLIC_KEY'
not_contains services/core/pom.xml 'backend-judge-runtime'

source "$ROOT_DIR/scripts/dev/devstack-manifest.sh"
Expand Down
Loading