fix: add state-aware accessible names to icon-only controls - #18
Merged
DevOlabode merged 1 commit intoSep 18, 2026
Merged
DevOlabode merged 1 commit into
DevOlabode merged 1 commit into
Conversation
Theme toggle now announces Switch to dark/light theme instead of a static Toggle theme label. Decorative icons stay hidden from AT. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
|
@cursoragent is attempting to deploy a commit to the solabode499-5056's projects Team on Vercel. A member of the Team first needs to authorize it. |
dyk1454683243-sudo
marked this pull request as ready for review
September 18, 2026 02:25
DevOlabode
approved these changes
Sep 18, 2026
DevOlabode
left a comment
DevOlabode
left a comment
Owner
There was a problem hiding this comment.
Approving - this is the more complete fix for #11: covers the theme-toggle label/state plus the decorative icon aria-hidden cleanup and per-item delete button titles. Verified the interpolated title/name values are already escapeHtml'd upstream, so no XSS concern. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Audits icon-only controls in the extension popup and makes
#theme-toggleannounce the theme it will switch to, instead of a static "Toggle theme" label.#theme-togglenow uses "Switch to dark theme" / "Switch to light theme" for botharia-labelandtitle, and updates after init and each toggle◐,⚙,×) are markedaria-hiddenso the accessible name comes from the labeltitlenow matches the specific itemNo behavior changes beyond labeling/state. Theme persistence and click handling are unchanged.
Keyboard: these controls are native
<button>elements, are nottabindex="-1", and.icon-btndoes not remove focus outlines.Related Issue
Closes #11
Type of Change
Screenshots
N/A — labeling/state only; no visual design change.
Checklist