Skip to content

fix: add state-aware accessible names to icon-only controls #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DevOlabode merged 1 commit into from
Sep 18, 2026
Merged

fix: add state-aware accessible names to icon-only controls #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions extension/popup/popup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@
<span class="brand-name">Curate</span>
</div>
<div class="header-actions">
<button id="theme-toggle" class="icon-btn" type="button" aria-label="Toggle theme" title="Toggle theme">
<button id="theme-toggle" class="icon-btn" type="button" aria-label="Switch to dark theme" title="Switch to dark theme">
<span aria-hidden="true">◐</span>
</button>
<button id="open-settings" class="icon-btn" type="button" aria-label="Settings" title="Settings" hidden>⚙</button>
<button id="open-settings" class="icon-btn" type="button" aria-label="Settings" title="Settings" hidden>
<span aria-hidden="true">⚙</span>
</button>
</div>
</header>

Expand Down
22 changes: 18 additions & 4 deletions extension/popup/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ function bookmarkRowHtml(bookmark) {
</a>
<div class="item-actions">
<button class="text-btn" type="button" data-edit="${bookmark._id}" aria-label="Edit ${title}">Edit</button>
<button class="icon-btn icon-btn-danger" type="button" data-delete="${bookmark._id}" aria-label="Delete ${title}" title="Delete">×</button>
<button class="icon-btn icon-btn-danger" type="button" data-delete="${bookmark._id}" aria-label="Delete ${title}" title="Delete ${title}"><span aria-hidden="true">×</span></button>
</div>
`;
}
Expand Down Expand Up @@ -195,7 +195,7 @@ function renderCollections(collections) {
<span class="collection-meta">${count} bookmark${count === 1 ? '' : 's'}</span>
${collection.description ? `<span class="collection-desc">${escapeHtml(collection.description)}</span>` : ''}
</button>
<button class="icon-btn icon-btn-danger" type="button" data-delete-collection="${collection._id}" aria-label="Delete ${escapeHtml(collection.name)}" title="Delete">×</button>
<button class="icon-btn icon-btn-danger" type="button" data-delete-collection="${collection._id}" aria-label="Delete ${escapeHtml(collection.name)}" title="Delete ${escapeHtml(collection.name)}"><span aria-hidden="true">×</span></button>
`;
collectionList.appendChild(item);
});
Expand Down Expand Up @@ -660,10 +660,24 @@ deleteForm.addEventListener('submit', async (event) => {
}
});

function applyThemeToggleState(theme) {
const toggle = $('#theme-toggle');
if (!toggle) return;
const nextTheme = theme === 'dark' ? 'light' : 'dark';
const label = `Switch to ${nextTheme} theme`;
toggle.setAttribute('aria-label', label);
toggle.setAttribute('title', label);
}

function applyTheme(theme) {
document.documentElement.setAttribute('data-theme', theme);
applyThemeToggleState(theme);
}

$('#theme-toggle').addEventListener('click', async () => {
const current = document.documentElement.getAttribute('data-theme') || 'light';
const next = current === 'dark' ? 'light' : 'dark';
document.documentElement.setAttribute('data-theme', next);
applyTheme(next);
await setTheme(next);
});

Expand All @@ -690,7 +704,7 @@ document.querySelectorAll('.password-toggle').forEach((btn) => {

async function initTheme() {
const theme = await getTheme();
document.documentElement.setAttribute('data-theme', theme);
applyTheme(theme);
const forgotLink = $('#forgot-password-link');
if (forgotLink) {
forgotLink.href = `${await getApiBaseUrl()}/forgot-password`;
Expand Down
Loading