Support predicate callbacks in fake index assertions#4
Merged
Conversation
stevebauman
marked this pull request as ready for review
July 24, 2026 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
IndexBlueprint.IndexBlueprint,Mapping, andSettingsassertions for backward compatibility.false.Why
The fake previously treated expected mapping and settings objects as exact operation definitions. This made higher-level assertions fail when an index was created with mapping or settings data that the assertion did not explicitly rebuild. Assertion callbacks should inspect the operation that was actually recorded, following the same predicate semantics used by Laravel's fakes.
Developer impact
Consumers can now assert only that an operation occurred:
They can optionally add a predicate when the recorded definition matters, while existing exact-object assertions continue to work.