Prevent blocked distance checks in reopened party and raid menus - #1982
Merged
EllesmereGaming merged 1 commit intoSep 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents the remaining range-gated entries in EUI's reopened party/raid player menu from evaluating
CheckInteractDistanceunder tainted execution.The classifier fallback can reopen a player menu from addon Lua. Blizzard's enabled predicates for Trade, Duel, Pet Battle Duel, and Compare Achievements call
CheckInteractDistance, which can produceADDON_ACTION_BLOCKED. Extend the existing disabled-entry list to grey out those four actions only in that fallback menu, replacing their enabled predicates before menu initialization. Ordinary menus retain their actions and distance checks.This addresses a menu-error path consistent with NameeR's v9.0.7 report. The separate symptom of remaining stuck in a raid after leaving has not been reproduced or established as caused by this error; this PR does not claim to fix that state.
How was it tested?
SetEnabledhandling in the local interface export.git diff --checkpass. Syntax checked with available Lua 5.4luac; the added code uses only Lua 5.1 syntax.Reproduction/regression checklist (individual outcomes not separately recorded): trigger the fallback for a party/raid player in another zone and verify the menu opens without the blocked call; verify normal nearby-player interactions remain available; separately verify leaving a raid clears the roster display, including after
/reload.Screenshots
Before/after screenshots are not available. The visible change is four additional greyed-out entries in the reopened fallback menu only.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames - only the existing supported menu-descriptionSetEnabled(false)customization is extended; no frame writes added.