Skip to content

Prevent blocked distance checks in reopened party and raid menus #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EllesmereGaming merged 1 commit into from
Sep 7, 2026
+8 −0
Merged

Prevent blocked distance checks in reopened party and raid menus #1982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions EllesmereUI_MenuFallbacks.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,10 +384,18 @@ local function ModifyReopenedMenu(owner, rootDescription, contextData)
local setFocus = SET_FOCUS or "Set Focus"
local follow = FOLLOW or "Follow"
local raidTarget = RAID_TARGET_ICON or "Raid Target Icon"
local trade = TRADE or "Trade"
local duel = DUEL or "Duel"
local petDuel = PET_BATTLE_PVP_DUEL or "Pet Battle Duel"
local achievements = COMPARE_ACHIEVEMENTS or "Compare Achievements"
for _, d in rootDescription:EnumerateElementDescriptions() do
local text = MenuUtil.GetElementText(d)
if d.SetEnabled and (text == setFocus or text == follow or text == raidTarget
or text == trade or text == duel or text == petDuel or text == achievements
or (HOUSING_OK and text == viewHouses)) then
-- Range-gated entries call CheckInteractDistance from Blizzard's
-- enabled predicate. Disable them before that predicate can run in
-- this tainted reopen; normal secure menus keep their range checks.
-- Protected from a tainted menu: throws (focus/follow, and every
-- marker under Raid Target Icon -- SetRaidTarget) or poisons
-- HouseListFrame for the session (View Houses; the docked button
Expand Down