Skip to content

fix(chat): restore tab spacing and even out the first scrolling gap - #2011

Merged
EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
dfrisone:fix/chat-tab-spacing
Sep 8, 2026
Merged

fix(chat): restore tab spacing and even out the first scrolling gap#2011
EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
dfrisone:fix/chat-tab-spacing

Conversation

@dfrisone

@dfrisone dfrisone commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes Tab Spacing being ignored and the uneven gap between pinned and scrolling chat tabs, reported by Railgun on 9.1.6. This restores the spacing behavior addressed in #1000 for the current ghost-tab renderer.

The slider saved tabSpacing, but the renderer never read it. Blizzard leaves one UI unit between tabs within each group and no additional gap before the first scrolling tab. Apply the configured spacing as an inset on EUI's visual tab, compensating for that boundary. Backgrounds and borders follow the same rectangle. Blizzard's tab positions, sizes and click areas remain unchanged; larger spacing narrows the visible label area. Tabs Inside Chat Panel keeps its existing layout.

How was it tested?

  • In-game validation reported by Don: Mythic+ dungeon, LFR and open world with /euidev enabled. Spacing was visually fixed and no taint was observed. Exact client build was not recorded.
  • Lua 5.1: full-file syntax passed. The actual edited anchoring block passed 96 mocked combinations of pinned/scrolling groups, spacing 0/1/3/10, pixel scales and panel mode. The unmodified code fails the same harness. Blizzard-tab proxies reject writes and unexpected method calls.
  • Static taint review found no new Blizzard-frame writes or restricted-value reads in the diff. No new hooks, events, timers or per-frame work; only constant arithmetic in the existing refresh pass.
  • Changed-line EUI style gate passed. Locale extraction produced no content changes.

Screenshots

After: General, Combat Log, Trade and DMs tabs with aligned borders.

Chat tab spacing after the fix

Before screenshots were supplied with the original report but are not attached here.

Checklist

  • New settings default OFF (no behavior change without opt-in) -- N/A: no new settings; fixes the existing spacing setting.
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built -- this diff adds none; existing lifecycle unchanged.
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations) -- no new scheduling or allocations.
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames -- changes only EUI-owned ghost anchors.
  • Tested in-game on live; no version gates or pre-Midnight APIs added -- M+, LFR and open world with /euidev, as reported above.

Satisfying alignment

@EllesmereGaming
EllesmereGaming merged commit b032538 into EllesmereGaming:main Sep 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants