fix(chat): restore tab spacing and even out the first scrolling gap - #2011
Merged
EllesmereGaming merged 1 commit intoSep 8, 2026
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Tab Spacing being ignored and the uneven gap between pinned and scrolling chat tabs, reported by Railgun on 9.1.6. This restores the spacing behavior addressed in #1000 for the current ghost-tab renderer.
The slider saved
tabSpacing, but the renderer never read it. Blizzard leaves one UI unit between tabs within each group and no additional gap before the first scrolling tab. Apply the configured spacing as an inset on EUI's visual tab, compensating for that boundary. Backgrounds and borders follow the same rectangle. Blizzard's tab positions, sizes and click areas remain unchanged; larger spacing narrows the visible label area. Tabs Inside Chat Panel keeps its existing layout.How was it tested?
/euidevenabled. Spacing was visually fixed and no taint was observed. Exact client build was not recorded.Screenshots
After: General, Combat Log, Trade and DMs tabs with aligned borders.
Before screenshots were supplied with the original report but are not attached here.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames -- changes only EUI-owned ghost anchors./euidev, as reported above.