Skip to content

ci: run PR workflows on every base branch (probe) - #12

Closed
Fl0p wants to merge 1 commit into
base/upstream-dev-flo896from
flo-896-ci-triggers
Closed

Fl0p wants to merge 1 commit into
base/upstream-dev-flo896from
flo-896-ci-triggers

Conversation

@Fl0p

@Fl0p Fl0p commented Sep 12, 2026

Copy link
Copy Markdown

Probe PR. Do not merge - it exists to prove that the trigger patch makes real build/lint/test jobs run on a pull request whose base is not main.

Base base/upstream-dev-flo896 is a verbatim snapshot of upstream/dev (80430fd2862bfb43a6b0b1993f57033e45a9b98b); the only diff is the one commit below.

What changed

.github/workflows/ci.yml and .github/workflows/smoke-test.yml: drop the branches: filter under pull_request:. push: stays pinned to main. 2 files, -2 lines, nothing else.

Why it has to live here

GitHub Actions resolves a pull_request workflow definition from the PR's own tree (head / merge commit), never from the default branch. Only schedule / workflow_dispatch / workflow_run / repository_dispatch are read from the default branch. So patching the fork's main alone produces zero runs on a PR into a review base.

Expected result

Lint (TS), the build jobs and Smoke Test (Mock Mode) appear with non-zero durations instead of only Labeler / Greetings / Validate PR Title. Red real jobs are an acceptable outcome here: the upstream ci.yml carries drift/parity gates that may not pass on a bare snapshot. The point is that the signal exists.

The `pull_request` trigger in `ci.yml` and `smoke-test.yml` was pinned to
`main`, so a pull request opened against any other base branch got no lint,
build or test run at all - only the unconditional metadata checks. GitHub
resolves a `pull_request` workflow definition from the PR's own tree, never
from the default branch, so the patch has to be present in the branch under
test. `push` stays pinned to `main`.

Co-Authored-By: Wayland <wayland@agents.flopbut.local>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ffdf96c8-be11-4864-bc8a-5865bb9ec727

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Fl0p

Fl0p commented Sep 12, 2026

Copy link
Copy Markdown
Author

Probe PR - its purpose was to prove that removing the branches filter under pull_request: makes real lint/build/test jobs run on a PR whose base is not main. It did (Lint (TS) 4m48s, Test Matrix both nodes, smoke-test pass). The patch is merged to main via #13; closing the probe and deleting its branches. The three red jobs are a defect in upstream snapshot 80430fd (FStringView missing from the native-discovery ue-shim), unrelated to the trigger change and tracked separately.

@Fl0p Fl0p closed this Sep 12, 2026
@Fl0p
Fl0p deleted the flo-896-ci-triggers branch September 12, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant