Repository navigation
ci: run PR workflows on every base branch - #13
Merged
Merged
Conversation
The `pull_request` trigger in `ci.yml` and `smoke-test.yml` was pinned to `main`, so a pull request opened against any other base branch got no lint, build or test run at all - only the unconditional metadata checks. GitHub resolves a `pull_request` workflow definition from the PR's own tree, never from the default branch, so the patch has to be present in the branch under test. `push` stays pinned to `main`. Also document the mechanics: why a default-branch-only edit is a no-op, how to cut a review base so the trigger patch stays out of the review diff, that the patch must not be forwarded upstream, and that the dependency graph behind `dependency-review` is a repository setting rather than anything in the workflow files. Co-Authored-By: Wayland <wayland@agents.flopbut.local> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the
branches:filter underpull_request:inci.ymlandsmoke-test.yml, and documents the mechanics indocs/fork-ci-review-bases.md.Why
A PR into a
base/upstream-dev-*review base got no lint, no build and no tests - only Labeler / Greetings / Validate PR Title. GitHub Actions resolves apull_requestworkflow definition from the PR's own tree (head or merge commit), never from the default branch, so this change onmainalone does not fix any existing PR - it fixes every PR cut frommainafterwards, and it is the canonical copy of the patch review bases carry.push:is untouched and stays pinned tomain.Diff
.github/workflows/ci.yml-1.github/workflows/smoke-test.yml-1docs/fork-ci-review-bases.mdnew, 72 linesThe workflow diff is deliberately 2 files / -2 lines: the fork syncs with upstream periodically, and anything more in
.github/workflows/**becomes a merge conflict later. The doc is a new filename for the same reason.Verified
Probe PR #12 (
flo-896-ci-triggers->base/upstream-dev-flo896, a verbatim snapshot ofupstream/dev80430fd2) carries the same 2-line patch, andgh pr checkson it lists real jobs with the expectedpending-> run transition:Lint (TS),Test Matrix (Node 20.19 / 26)(both legs),smoke-test, plusdependency-reviewgreen. Job URLs and durations are in the issue thread. #12 is a probe and is not for merging.docs/fork-ci-review-bases.mdalso records that the previously always-reddependency-reviewwas fixed by enabling the repository's dependency graph, not by any workflow edit.