rendering: make shared GL infrastructure profile-safe - #15
Closed
tritao wants to merge 2 commits into
Closed
Conversation
tritao
changed the title
tritao
force-pushed
the
stack/shared-gl-paths
branch
from
August 8, 2026 00:17
27dc5aa to
a9afb3d
Compare
tritao
force-pushed
the
stack/profile-neutral-shaders
branch
from
August 8, 2026 00:17
b23f376 to
431c5ba
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
from
August 8, 2026 00:42
a9afb3d to
7700012
Compare
tritao
force-pushed
the
stack/profile-neutral-shaders
branch
2 times, most recently
from
August 8, 2026 01:07
f5553c1 to
2fe3d9f
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
3 times, most recently
from
August 8, 2026 01:22
3bad944 to
b2a9ffc
Compare
tritao
force-pushed
the
stack/profile-neutral-shaders
branch
2 times, most recently
from
August 8, 2026 01:24
9320737 to
bd05d5c
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
2 times, most recently
from
August 8, 2026 01:30
3358ad3 to
91c41a1
Compare
tritao
force-pushed
the
stack/profile-neutral-shaders
branch
from
August 8, 2026 01:30
bd05d5c to
0eb81d6
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
from
August 8, 2026 01:51
91c41a1 to
a2f6a79
Compare
tritao
force-pushed
the
stack/profile-neutral-shaders
branch
2 times, most recently
from
August 8, 2026 01:57
9dcdd77 to
c87b65d
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
from
August 8, 2026 01:57
a2f6a79 to
4aa73d6
Compare
tritao
force-pushed
the
stack/profile-neutral-shaders
branch
from
August 8, 2026 02:04
c87b65d to
786c928
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
2 times, most recently
from
August 8, 2026 02:32
6f9c692 to
41465e0
Compare
tritao
changed the base branch from
stack/profile-neutral-shaders
to
stack/shader-diagnostics
August 8, 2026 02:36
tritao
marked this pull request as ready for review
August 8, 2026 02:36
tritao
changed the title
tritao
force-pushed
the
stack/shared-gl-paths
branch
from
August 8, 2026 02:54
41465e0 to
6d6559f
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 10:27
2de6681 to
1f27e2c
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
from
August 8, 2026 10:27
6d6559f to
48084b6
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 11:06
1f27e2c to
130303e
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
from
August 8, 2026 11:06
48084b6 to
7d75b3a
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 11:41
130303e to
b5eebe2
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
from
August 8, 2026 11:41
7d75b3a to
4b38aae
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 12:06
b5eebe2 to
bd689d5
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
from
August 8, 2026 12:06
4b38aae to
ca13128
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 13:43
bd689d5 to
d4d9d02
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
3 times, most recently
from
August 8, 2026 20:31
ad78dae to
759d789
Compare
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 20:31
d4d9d02 to
0523569
Compare
Keep runtime profile detection and offscreen readback changes in the shared rendering layer. Select texture formats through the GL glue based on the active context, and preserve readback state without issuing compatibility-only pixel transfer operations in core contexts. Legacy texture and index-buffer helpers stay outside this layer so the compatibility boundary remains the owner of fixed-function resource behavior.
tritao
force-pushed
the
stack/shader-diagnostics
branch
from
August 8, 2026 20:44
0523569 to
e1be85f
Compare
tritao
force-pushed
the
stack/shared-gl-paths
branch
from
August 8, 2026 20:44
759d789 to
8378d36
Compare
Collaborator
Author
|
Superseded by PR #16, which now contains the shared GL profile-safety and offscreen readback changes together with the LegacyGL boundary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep shared OpenGL infrastructure profile-safe without turning legacy resource helpers into a second modern backend.
SoVertexArrayIndexeroutside this shared layer.Progressive validation
The inherited core EGL and GLSL checks are extended with a focused
CoinOffscreenGLCanvas::readPixels()test. It creates a core surfaceless context, clears a known color, reads RGBA pixels, and verifies the result.Scope
This layer contains only shared GL glue, offscreen readback changes, and their focused validation. It does not add a core-profile EBO path to
SoVertexArrayIndexeror modern texture swizzles and mipmap handling toSoGLImage. The compatibility boundary owns legacy traversal and those legacy helpers.Stack
Layer 5/9, based on PR #22.