gl: make shared OpenGL infrastructure profile-safe by tritao · Pull Request #16 · FreeCAD/coin

tritao · 2026-08-07T13:59:16Z

Summary

Make Coin's shared OpenGL infrastructure safe to execute on both compatibility and core-profile contexts.

Separate shared context/glue functionality from legacy fixed-function drawing assumptions.
Replace compatibility-only queries and state handling in shared code with profile-safe equivalents.
Keep low-level GL legality and profile differences inside the shared glue layer.
Preserve required OpenGL state during offscreen readback.
Make shared texture probing and context helpers safe on core profiles.
Add focused core-profile readback and shared-infrastructure coverage.

This layer does not remove LegacyGL scene traversal or exclude LegacyGL implementation units; those boundaries are introduced next.

Stack

Layer 5/18, based on PR #22.

Lgt2x · 2026-08-19T09:33:44Z

      - name: Build EGL binding test
-        run: cmake --build cmake_build_dir --target EGLBindingTest GLSLRuntimeTest --config Release -- -j4
+        run: cmake --build cmake_build_dir --target EGLBindingTest GLSLRuntimeTest OffscreenReadbackTest --config Release -- -j4
      - name: Run core-profile OpenGL tests
-        run: ctest -C Release -R '^(EGLBindingTest|GLSLRuntimeTest)$' --output-on-failure
+        run: ctest -C Release -R '^(EGLBindingTest|GLSLRuntimeTest|OffscreenReadbackTest)$' --output-on-failure


I'm still unsure why we separate test runs in multiple passes and jobs instead of running all of them at once

The passes intentionally isolate environments: generic GLFW/core tests run under Xvfb without EGL settings, while EGL-specific contract tests run separately.

Lgt2x · 2026-08-19T09:34:50Z

+	add_executable(OffscreenReadbackTest OffscreenReadbackTest.cpp)
+	target_link_libraries(OffscreenReadbackTest PRIVATE
+		CoinGLTestSupport CoinGLReadbackTestSupport CoinTestInternals Coin
+		${COIN_TARGET_LINK_LIBRARIES})
+	target_include_directories(OffscreenReadbackTest PRIVATE
+		${PROJECT_SOURCE_DIR}/src
+		${PROJECT_SOURCE_DIR}/include
+		${PROJECT_BINARY_DIR}/include
+		${COIN_TARGET_INCLUDE_DIRECTORIES})
+	add_test(NAME OffscreenReadbackTest COMMAND OffscreenReadbackTest)
+	set_tests_properties(OffscreenReadbackTest PROPERTIES
+		SKIP_RETURN_CODE 77 LABELS "gl-core")


we're starting to have a lot of redundancy here, you can make proper function to add gl tests 2 PRs up the stack

Fixed in the shared test layer. This now registers the readback test through the coin_add_gl_test() helper.

Lgt2x · 2026-08-19T09:35:39Z

        run: |
          sudo apt-get -y update
-          sudo apt-get -y install freeglut3-dev
+          sudo apt-get -y install freeglut3-dev libglfw3-dev


technically it's installed automatically by the testsuite, but I prefer to install it on the system like this

GLFW is now provisioned externally by CI through the dependency script; CMake no longer downloads it.

Lgt2x · 2026-08-19T09:42:05Z

+#else
+    (void)index;
+    (void)point;
+    (void)normal;
+#endif


So if Coin is not build with legacy gl here, it's a noop? Is the class in a broken state temporarily with this PR?

Good catch. I removed those compile-time bundle changes from this, so the public methods no longer silently become no-ops. LegacyGL implementation isolation remains owned by the later dedicated layer.

tritao · 2026-08-19T13:50:00Z

All feedback should now be addressed.

tritao force-pushed the stack/compatibility-boundary branch from 0f14f15 to f09c6b7 Compare August 7, 2026 23:57

tritao changed the title ~~stack/compatibility boundary~~ build: complete compatibility-profile boundaries Aug 8, 2026

tritao mentioned this pull request Aug 8, 2026

build: add platform GL header plumbing #19

Closed

tritao force-pushed the stack/compatibility-boundary branch from f09c6b7 to 438c680 Compare August 8, 2026 00:17

tritao force-pushed the stack/compatibility-boundary branch from 438c680 to 9d5aa7b Compare August 8, 2026 00:42

tritao force-pushed the stack/compatibility-boundary branch from 9d5aa7b to 17f663a Compare August 8, 2026 01:07

tritao force-pushed the stack/compatibility-boundary branch from 17f663a to 5534301 Compare August 8, 2026 01:20

tritao force-pushed the stack/compatibility-boundary branch from 5534301 to 1898f72 Compare August 8, 2026 01:22

tritao force-pushed the stack/compatibility-boundary branch from 1898f72 to 00e03cf Compare August 8, 2026 01:24

tritao force-pushed the stack/compatibility-boundary branch from 00e03cf to 32b1cf7 Compare August 8, 2026 01:30

tritao force-pushed the stack/compatibility-boundary branch 2 times, most recently from e850c17 to 0503981 Compare August 8, 2026 01:57

tritao force-pushed the stack/compatibility-boundary branch from 0503981 to 4b9f662 Compare August 8, 2026 02:04

tritao force-pushed the stack/compatibility-boundary branch from 4b9f662 to 9e20664 Compare August 8, 2026 02:32

tritao marked this pull request as ready for review August 8, 2026 02:36

tritao force-pushed the stack/compatibility-boundary branch from 9e20664 to 654a702 Compare August 8, 2026 02:54

tritao force-pushed the stack/compatibility-boundary branch from 0af09b0 to 96e1679 Compare August 8, 2026 10:27

tritao changed the title ~~build: isolate the legacy OpenGL boundary~~ build: make shared GL core-safe and isolate LegacyGL Aug 8, 2026

tritao mentioned this pull request Aug 8, 2026

rendering: make shared GL infrastructure profile-safe #15

Closed

tritao force-pushed the stack/compatibility-boundary branch from eb617ed to 7a2272e Compare August 9, 2026 02:03

tritao force-pushed the stack/compatibility-boundary branch from 7a2272e to 4f38785 Compare August 9, 2026 02:35

This was referenced Aug 9, 2026

shaders: migrate GLSL to profile-neutral dispatch #14

Merged

rendering: add backend-neutral retained IR #28

Open

tritao force-pushed the stack/compatibility-boundary branch 3 times, most recently from 777ae7b to 293984a Compare August 9, 2026 11:37

tritao force-pushed the stack/compatibility-boundary branch 2 times, most recently from b1748c3 to 0f0c8b0 Compare August 9, 2026 12:02

tritao changed the title ~~build: make shared GL core-safe and isolate LegacyGL~~ gl: make shared OpenGL infrastructure profile-safe Aug 9, 2026

tritao force-pushed the stack/compatibility-boundary branch 2 times, most recently from 79e6932 to 626fb23 Compare August 9, 2026 14:55

tritao force-pushed the stack/compatibility-boundary branch from 626fb23 to 8083b63 Compare August 9, 2026 15:10

tritao force-pushed the stack/compatibility-boundary branch 2 times, most recently from a8f3ebf to bc0c4c3 Compare August 9, 2026 21:01

tritao mentioned this pull request Aug 11, 2026

rendering: make LegacyGL traversal optional #38

Open

Lgt2x reviewed Aug 19, 2026

View reviewed changes

tritao added 3 commits August 19, 2026 14:55

gl: separate shared context helpers from legacy drawing

1c4e55e

gl: make shared OpenGL infrastructure profile-safe

cdbeb81

tests: cover core-profile shared GL infrastructure

4bd9b53

Navigation Menu

Uh oh!

gl: make shared OpenGL infrastructure profile-safe - #16

gl: make shared OpenGL infrastructure profile-safe#16
tritao wants to merge 3 commits into
stack/shader-diagnosticsfrom
stack/compatibility-boundary

tritao commented Aug 7, 2026 •

edited

Loading

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

tritao Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

tritao Aug 19, 2026 •

edited

Loading

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

tritao Aug 19, 2026

Uh oh!

Lgt2x Aug 19, 2026

Uh oh!

tritao Aug 19, 2026 •

edited

Loading

Uh oh!

tritao commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tritao commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Stack

Uh oh!

Lgt2x Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

tritao Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

Lgt2x Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

tritao Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lgt2x Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

tritao Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

Lgt2x Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

tritao Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tritao commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tritao commented Aug 7, 2026 •

edited

Loading

tritao Aug 19, 2026 •

edited

Loading

tritao Aug 19, 2026 •

edited

Loading