ci: group non-PR workflow runs per commit so queued runs are not replaced - #395
Merged
Merged
Conversation
…aced #376 made push, schedule and dispatch runs on main use a per-ref group without cancel-in-progress. That stopped in-progress cancellation, but a concurrency group still holds at most one pending run and a newer queued run replaces it. During back-to-back merges on 2026-09-15 the CI and Benchmark push runs for 82dba99 and ecb0c78 were cancelled before any job started. Notebook smoke still used cancel-in-progress: true and was cancelled mid-run. Group pull_request runs by ref as before, so a new PR push still cancels its superseded run, and group every other run by commit SHA so each merged commit keeps its own complete result. Apply the same to CI, Benchmark, Performance regression and Notebook smoke. Docs is left as is: it deploys gh-pages, where the newest deploy should win.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
FreshData benchmark report —
|
| fixture | n_rows | n_cols | p50 s | p95 s | peak MB | repair % | false-repair % | preserve % | trust | monotonic | export % |
|---|
Authored-code reduction (Metric 6)
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workflow runs that aren't pull requests are now grouped per commit. When PRs merge back to back, every merged commit keeps its own CI, Benchmark, Performance regression and Notebook smoke result, and a newer queued run no longer replaces an older commit's queued run.
Why
#376 changed push, schedule and dispatch runs on
mainto a per-ref group withcancel-in-progress: false. That stops in-progress runs being cancelled, but a concurrency group still holds at most one pending run, and a newer queued run replaces it. In the merges on 2026-09-15:notebooks.ymlstill hadcancel-in-progress: true)Change
This is applied to
ci.yml,benchmark.yml,perf-regression.ymlandnotebooks.yml....-pull_request-refs/pull/N/merge, so a new push cancels the superseded run.Checks
concurrencyblock resolves as shown above.tests/performance/test_contracts.py,tests/test_phase5_backcompat.pyandtests/test_wheel_artifact_policy.pypass on Python 3.9 and 3.12 (23 tests). No test asserts on the concurrency text.