test(numeric): list only files that still have direct to_numeric calls - #411
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Only enterprise/contracts.py has direct pd.to_numeric calls left. The other entries in _DEFERRED had no references, so the static guard never counted them; drop them so the list stays accurate, and fail the test when a _DEFERRED entry has no direct calls so the list cannot go stale again.
kevincostner17
force-pushed
the
test/numeric-deferred-list
branch
from
September 15, 2026 13:34
9ef2c29 to
c6b5211
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows up #409. The static guard in
tests/test_numeric.pyskips files listed in_DEFERRED. Several of those files have no directpd.to_numericcalls, so skipping them does nothing. Onlyenterprise/contracts.pystill has direct calls (4)._DEFERREDnow lists onlyenterprise/contracts.py, so a new direct call in any other file fails the test._DEFERREDentry has no direct calls, so the list can't go stale again.This changes tests only; there are no source changes.
Verification
ruff check tests/test_numeric.py: passedpytest tests/test_numeric.py: 230 passed on Python 3.12, 205 passed on Python 3.9