Skip to content

test(numeric): list only files that still have direct to_numeric calls #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevincostner17 merged 1 commit into from
Sep 15, 2026
Merged

test(numeric): list only files that still have direct to_numeric calls #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions tests/test_numeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,20 +373,8 @@ def _tripwire(arg, *args, **kwargs):

_PACKAGE = Path(freshdata.__file__).resolve().parent

# Left for a follow-up PR.
_DEFERRED = frozenset({
"enterprise/contracts.py",
"enterprise/privacy.py",
"enterprise/privacy_policy.py",
"enterprise/cleaner.py",
"enterprise/interface.py",
"learning/privacy.py",
"experimental/ai_copilot.py",
"_util.py",
"parsers/base.py",
"execution/_config.py",
"execution/backends/_duckdb.py",
})
# Files whose direct calls are left for a follow-up PR.
_DEFERRED = frozenset({"enterprise/contracts.py"})

# Direct calls whose argument is provably numeric: pandas never runs its
# string parser on them. Counts must match exactly, so a new call in the same
Expand Down Expand Up @@ -429,3 +417,5 @@ def test_every_to_numeric_call_goes_through_safe_to_numeric():
)
stale = {rel for rel in _NUMERIC_ONLY if rel not in found}
assert not stale, f"update _NUMERIC_ONLY: {stale}"
stale_deferred = {rel for rel in _DEFERRED if not _to_numeric_references(_PACKAGE / rel)}
assert not stale_deferred, f"remove from _DEFERRED: {stale_deferred}"
Loading