header fastedge app

[ruslanti]

No description provided.

[Copilot]

Pull request overview

This PR standardizes handling of the server_name header across crates and extends HTTP request routing to support resolving applications by numeric ID via a new fastedge_app_id header, with additional tracing instrumentation and related test updates.

Changes:

• Introduce and adopt a shared SERVER_NAME_HEADER constant and adjust header propagation/derivation behavior.
• Add fastedge_app_id request header support by extending app identification to AppName::{Name, Id} and routing via lookup_by_id.
• Add tracing instrumentation and expand unit/integration tests around the updated routing logic.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Cargo.toml	Bumps workspace Rust edition to 2024.
src/main.rs	Uses shared SERVER_NAME_HEADER constant when auto-injecting headers.
src/executor.rs	Import ordering only.
src/context.rs	Import ordering only.
crates/runtime/src/util/stats.rs	Import ordering only (tests module).
crates/runtime/src/util/metrics.rs	Import ordering only.
crates/runtime/src/stub.rs	Import ordering only.
crates/runtime/src/store.rs	Import ordering only.
crates/runtime/src/registry.rs	Import ordering only / restructured import grouping.
crates/runtime/src/lib.rs	Import ordering only.
crates/http-service/src/state.rs	Adds tracing::instrument to backend_request.
crates/http-service/src/lib.rs	Adds AppName (name/id), fastedge_app_id parsing, lookup-by-id flow, and tests.
crates/http-service/src/executor/wasi_http.rs	Changes how authority/Host are derived for WASI HTTP execution (now based on backend hostname).
crates/http-service/src/executor/http.rs	Updates tests and router mock to support lookup-by-id; uses shared header constant.
crates/http-backend/src/lib.rs	Adds SERVER_NAME_HEADER, adjusts FastEdge host propagation to use configured backend hostname, and updates tests.

Comments suppressed due to low confidence (1)

crates/http-service/src/lib.rs:586

• to_str().unwrap() on server_name can panic on non-UTF8 header values, turning a bad request into a process crash. Prefer returning an error (e.g., to_str().context("server_name header is not valid UTF-8")?) so handle_request can map it to a 404/400 cleanly.

    match req.headers().get(SERVER_NAME_HEADER) {
        None => {}
        Some(h) => {
            let full_hostname = h.to_str().unwrap();
            match full_hostname.find('.') {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.