Skip to content

header fastedge app #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruslanti merged 6 commits into from
May 6, 2026
Merged

header fastedge app #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a93fece
feat: introduce `fastedge_app_id` header support and enhance app reso…
ruslanti May 6, 2026
7bfae4e
refactor: update `hostname` method to support `ToSmolStr` and enhance…
ruslanti May 6, 2026
14c1c24
chore: update Rust edition to 2024 and clean up static lifetime annot…
ruslanti May 6, 2026
2ef37d8
refactor: reformating all code after switch to 2024 rust edition
ruslanti May 6, 2026
eb2dc34
refactor: simplify header propagation logic with `&& let` chains
ruslanti May 6, 2026
a5a5fbc
refactor: use `SmolStr` for defaulting backend hostname and adjust tr…
ruslanti May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ resolver = "2"

[workspace.package]
version = "0.16.1"
edition = "2021"
edition = "2024"
publish = false
Comment thread
ruslanti marked this conversation as resolved.
authors = ["FastEdge Development Team"]

Expand Down
175 changes: 89 additions & 86 deletions crates/http-backend/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
pub mod stats;

use smol_str::SmolStr;
use smol_str::{SmolStr, ToSmolStr};
use std::fmt::Debug;
use std::future::Future;
use std::net::{IpAddr, Ipv4Addr, Ipv6Addr};
Expand All @@ -9,13 +9,13 @@ use std::sync::Arc;
use std::task::{Context, Poll};
use std::time::Duration;

use anyhow::{anyhow, Error, Result};
use http::{header, uri::Scheme, HeaderMap, HeaderName, Uri};
use anyhow::{Error, Result, anyhow};
use http::{HeaderMap, HeaderName, Uri, header, uri::Scheme};
use http_body_util::{BodyExt, Full};
use hyper::body::Bytes;
use hyper::rt::ReadBufCursor;
use hyper_util::client::legacy::connect::{Connect, HttpConnector};
use hyper_util::client::legacy::Client;
use hyper_util::client::legacy::connect::{Connect, HttpConnector};
use hyper_util::rt::TokioExecutor;
use pin_project::pin_project;
use tokio::net::TcpStream;
Expand All @@ -31,6 +31,8 @@ use reactor::gcore::fastedge::{

type HeaderNameList = Vec<HeaderName>;

pub const SERVER_NAME_HEADER: &str = "server_name";

#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum BackendStrategy {
Direct,
Expand Down Expand Up @@ -78,8 +80,8 @@ impl Builder {
self
}

pub fn hostname(&mut self, hostname: SmolStr) -> &mut Self {
self.hostname = Some(hostname);
pub fn hostname(&mut self, hostname: impl ToSmolStr) -> &mut Self {
self.hostname = Some(hostname.to_smolstr());
self
}

Expand Down Expand Up @@ -146,15 +148,11 @@ impl<C> Backend<C> {
pub fn propagate_headers(&mut self, headers: HeaderMap) -> Result<()> {
self.propagate_headers.clear();

if self.strategy == BackendStrategy::FastEdge {
let server_name = headers
.get("server_name")
.and_then(|v| v.to_str().ok())
.ok_or(anyhow!("header Server_name is missing"))?;
self.propagate_headers.insert(
HeaderName::from_static("host"),
be_base_domain(server_name).parse()?,
);
if self.strategy == BackendStrategy::FastEdge
&& let Some(ref hostname) = self.hostname
{
self.propagate_headers
.insert(header::HOST, hostname.parse()?);
}
let headers = headers.into_iter().filter(|(k, _)| {
if let Some(name) = k {
Expand Down Expand Up @@ -186,18 +184,16 @@ impl<C> Backend<C> {
if !headers
.iter()
.any(|(k, _)| k.eq_ignore_ascii_case(header::HOST.as_str()))
{
if let Ok(uri) = req.uri.parse::<Uri>() {
if let Some(host) = uri.authority().map(|a| {
if let Some(port) = a.port() {
format!("{}:{}", a.host(), port)
} else {
a.host().to_string()
}
}) {
headers.push((header::HOST.as_str().to_string(), host))
&& let Ok(uri) = req.uri.parse::<Uri>()
&& let Some(host) = uri.authority().map(|a| {
if let Some(port) = a.port() {
format!("{}:{}", a.host(), port)
} else {
a.host().to_string()
}
}
})
{
headers.push((header::HOST.as_str().to_string(), host))
}

let builder = http::Request::builder().uri(req.uri);
Expand Down Expand Up @@ -370,17 +366,6 @@ where
}
}

fn be_base_domain(server_name: &str) -> String {
let base_domain = match server_name.find('.') {
None => server_name,
Some(i) => {
let (_, domain) = server_name.split_at(i + 1);
domain
}
};
format!("be.{}", base_domain)
}

// extract canonical host name
fn canonical_host_name(headers: &Headers, original_uri: &Uri) -> Result<String> {
let host = headers.iter().find_map(|(k, v)| {
Expand Down Expand Up @@ -600,9 +585,9 @@ mod tests {
let connector = builder.build();
let mut backend =
Backend::<mock_http_connector::Connector>::builder(BackendStrategy::FastEdge)
.hostname("be.server")
.build(connector);
let mut headers = HeaderMap::new();
headers.insert("Server_name", claims::assert_ok!("server".try_into()));
let headers = HeaderMap::new();
claims::assert_ok!(backend.propagate_headers(headers));
let req = Request {
method: Method::Get,
Expand Down Expand Up @@ -632,9 +617,9 @@ mod tests {
let connector = builder.build();
let mut backend =
Backend::<mock_http_connector::Connector>::builder(BackendStrategy::FastEdge)
.hostname("be.server")
.build(connector);
let mut headers = HeaderMap::new();
headers.insert("Server_name", claims::assert_ok!("server".try_into()));
let headers = HeaderMap::new();
claims::assert_ok!(backend.propagate_headers(headers));
let req = Request {
method: Method::Get,
Expand Down Expand Up @@ -664,9 +649,9 @@ mod tests {
let connector = builder.build();
let mut backend =
Backend::<mock_http_connector::Connector>::builder(BackendStrategy::FastEdge)
.hostname("be.server")
.build(connector);
let mut headers = HeaderMap::new();
headers.insert("Server_name", claims::assert_ok!("server".try_into()));
let headers = HeaderMap::new();
claims::assert_ok!(backend.propagate_headers(headers));
let req = Request {
method: Method::Get,
Expand Down Expand Up @@ -725,9 +710,9 @@ mod tests {
let connector = builder.build();
let mut backend =
Backend::<mock_http_connector::Connector>::builder(BackendStrategy::FastEdge)
.hostname("be.server")
.build(connector);
let mut headers = HeaderMap::new();
headers.insert("Server_name", claims::assert_ok!("server".try_into()));
let headers = HeaderMap::new();
claims::assert_ok!(backend.propagate_headers(headers));
let req = Request {
method: Method::Get,
Expand Down Expand Up @@ -765,10 +750,10 @@ mod tests {
let connector = builder.build();
let mut backend =
Backend::<mock_http_connector::Connector>::builder(BackendStrategy::FastEdge)
.hostname("be.server")
.propagate_headers_names(vec!["Propagate-Header".parse().unwrap()])
.build(connector);
let mut headers = HeaderMap::new();
headers.insert("Server_name", claims::assert_ok!("server".try_into()));
headers.insert(
"No-Propagate-Header",
claims::assert_ok!("VALUE".try_into()),
Expand Down Expand Up @@ -803,11 +788,11 @@ mod tests {
let connector = builder.build();
let mut backend =
Backend::<mock_http_connector::Connector>::builder(BackendStrategy::FastEdge)
.hostname("be.server")
.propagate_headers_names(vec!["Propagate-Header".parse().unwrap()])
.uri(assert_ok!("http://be.server/backend_path/".parse()))
.build(connector);
let mut headers = HeaderMap::new();
headers.insert("Server_name", claims::assert_ok!("server".try_into()));
let headers = HeaderMap::new();

claims::assert_ok!(backend.propagate_headers(headers));
let req = Request {
Expand Down Expand Up @@ -838,11 +823,11 @@ mod tests {
let connector = builder.build();
let mut backend =
Backend::<mock_http_connector::Connector>::builder(BackendStrategy::FastEdge)
.hostname("be.server")
.propagate_headers_names(vec!["Propagate-Header".parse().unwrap()])
.max_sub_requests(2)
.build(connector);
let mut headers = HeaderMap::new();
headers.insert("Server_name", claims::assert_ok!("server".try_into()));
let headers = HeaderMap::new();

claims::assert_ok!(backend.propagate_headers(headers));
let req = Request {
Expand Down Expand Up @@ -987,10 +972,12 @@ mod tests {
};
let result = backend.make_request(req);
assert!(result.is_err());
assert!(result
.unwrap_err()
.to_string()
.contains("private host not allowed"));
assert!(
result
.unwrap_err()
.to_string()
.contains("private host not allowed")
);

// Test private network
let req = Request {
Expand All @@ -1001,10 +988,12 @@ mod tests {
};
let result = backend.make_request(req);
assert!(result.is_err());
assert!(result
.unwrap_err()
.to_string()
.contains("private host not allowed"));
assert!(
result
.unwrap_err()
.to_string()
.contains("private host not allowed")
);

// Test another private network
let req = Request {
Expand All @@ -1015,10 +1004,12 @@ mod tests {
};
let result = backend.make_request(req);
assert!(result.is_err());
assert!(result
.unwrap_err()
.to_string()
.contains("private host not allowed"));
assert!(
result
.unwrap_err()
.to_string()
.contains("private host not allowed")
);

// Test link-local
let req = Request {
Expand All @@ -1029,10 +1020,12 @@ mod tests {
};
let result = backend.make_request(req);
assert!(result.is_err());
assert!(result
.unwrap_err()
.to_string()
.contains("private host not allowed"));
assert!(
result
.unwrap_err()
.to_string()
.contains("private host not allowed")
);
}

#[test]
Expand All @@ -1050,10 +1043,12 @@ mod tests {
};
let result = backend.make_request(req);
assert!(result.is_err());
assert!(result
.unwrap_err()
.to_string()
.contains("private host not allowed"));
assert!(
result
.unwrap_err()
.to_string()
.contains("private host not allowed")
);

// Test with Host header containing private IP with port
let req = Request {
Expand All @@ -1064,10 +1059,12 @@ mod tests {
};
let result = backend.make_request(req);
assert!(result.is_err());
assert!(result
.unwrap_err()
.to_string()
.contains("private host not allowed"));
assert!(
result
.unwrap_err()
.to_string()
.contains("private host not allowed")
);
}

#[test]
Expand All @@ -1085,10 +1082,12 @@ mod tests {
};
let result = backend.make_request(req);
assert!(result.is_err());
assert!(result
.unwrap_err()
.to_string()
.contains("private host not allowed"));
assert!(
result
.unwrap_err()
.to_string()
.contains("private host not allowed")
);

// Test unique local
let req = Request {
Expand All @@ -1099,10 +1098,12 @@ mod tests {
};
let result = backend.make_request(req);
assert!(result.is_err());
assert!(result
.unwrap_err()
.to_string()
.contains("private host not allowed"));
assert!(
result
.unwrap_err()
.to_string()
.contains("private host not allowed")
);

// Test link-local
let req = Request {
Expand All @@ -1113,10 +1114,12 @@ mod tests {
};
let result = backend.make_request(req);
assert!(result.is_err());
assert!(result
.unwrap_err()
.to_string()
.contains("private host not allowed"));
assert!(
result
.unwrap_err()
.to_string()
.contains("private host not allowed")
);
}

#[test]
Expand Down
Loading
Loading