Skip to content

[Reviewed] [3D light] Handle the 3D renderer world scale for the point light range #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4ian merged 1 commit into from
Sep 30, 2026
Merged

[Reviewed] [3D light] Handle the 3D renderer world scale for the point light range #2280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions extensions/reviewed/Light3D.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"name": "Light3D",
"previewIconUrl": "https://asset-resources.gdevelop.io/public-resources/Icons/f237ae4e3b857c556846c7b2c0b132556fd4bcdeff217034b4d9c97dc1aab1d6_lightbulb-on-outline.svg",
"shortDescription": "A collection of light object for 3D.",
"version": "1.0.3",
"version": "1.0.4",
"description": "A collection of light object for 3D.",
"origin": {
"identifier": "Light3D",
Expand Down Expand Up @@ -434,7 +434,9 @@
" * @param value {number}",
" */",
" setRange(value) {",
" this.pointLight.distance = value;",
" const runtimeScene = this.object.getRuntimeScene();",
" const inverseWorldScale = runtimeScene.getRenderer3DInverseWorldScale ? runtimeScene.getRenderer3DInverseWorldScale() : 1;",
" this.pointLight.distance = value * inverseWorldScale;",
" }",
"",
" /**",
Expand Down
1 change: 1 addition & 0 deletions scripts/lib/ExtensionsValidatorExceptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,7 @@ const extensionsAllowedProperties = {
'__pointLight3DExtension',
'getScene',
'__lightManager',
'getRenderer3DInverseWorldScale',
],
javaScriptObjectAllowedProperties: ['getPrototypeOf'],
},
Expand Down
Loading