fix(Logger): replace warn with warning by BenPinet · Pull Request #197 · Geode-solutions/OpenGeode-IO

BenPinet · 2026-08-03T10:08:06Z

No description provided.

github-actions · 2026-08-03T10:11:43Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 27 concern(s)

include/geode/io/model/detail/vtm_output.hpp:57:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   57 | namespace geode
      | ^~~~~~~~~~~~~~~
   58 | {
      | ~
   59 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail

include/geode/io/model/detail/vtm_output.hpp:112:13: warning: [modernize-use-nodiscard]

function 'prefix' should be marked [[nodiscard]]
```
  112 |             std::string_view prefix() const
      |             ^
      |             [[nodiscard]] 
```
include/geode/io/model/detail/vtm_output.hpp:117:13: warning: [modernize-use-nodiscard]

function 'files_directory' should be marked [[nodiscard]]
```
  117 |             std::string_view files_directory() const
      |             ^
      |             [[nodiscard]] 
```
include/geode/io/model/detail/vtm_output.hpp:144:34: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  144 |                 for( const auto& id : corner_ids )
      |                                  ^
```
include/geode/io/model/detail/vtm_output.hpp:201:34: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  201 |                 for( const auto& id : line_ids )
      |                                  ^
```

include/geode/io/model/detail/vtm_output.hpp:242:18: warning: [readability-function-cognitive-complexity]

function 'write_surfaces' has cognitive complexity of 12 (threshold 10)

  242 |             void write_surfaces( pugi::xml_node& surface_block )
      |                  ^
/__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/model/detail/vtm_output.hpp:252:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  252 |                 for( const auto& surface : this->mesh().surfaces() )
      |                 ^
/__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/model/detail/vtm_output.hpp:258:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  258 |                 for( const auto& id : surface_ids )
      |                 ^
/__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/model/detail/vtm_output.hpp:267:21: note: +2, including nesting penalty of 1, nesting level increased to 2
  267 |                     if( is_new )
      |                     ^
/__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/model/detail/vtm_output.hpp:272:21: note: +1, nesting level increased to 2
  272 |                     else
      |                     ^
/__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/model/detail/vtm_output.hpp:284:54: note: nesting level increased to 2
  284 |                     tasks[counter++] = async::spawn( [&surface, this] {
      |                                                      ^
/__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/model/detail/vtm_output.hpp:288:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  288 |                         if( const auto* triangulated = dynamic_cast<
      |                         ^
/__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/model/detail/vtm_output.hpp:294:30: note: +1, nesting level increased to 3
  294 |                         else if( const auto* polygonal = dynamic_cast<
      |                              ^
/__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/model/detail/vtm_output.hpp:300:30: note: +1, nesting level increased to 3
  300 |                         else if( const auto* grid =
      |                              ^
/__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/model/detail/vtm_output.hpp:306:25: note: +1, nesting level increased to 3
  306 |                         else
      |                         ^
/__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/model/detail/vtm_output.hpp:318:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  318 |                 for( auto& task : all_tasks.get() )
      |                 ^

include/geode/io/model/detail/vtm_output.hpp:258:34: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  258 |                 for( const auto& id : surface_ids )
      |                                  ^
```
src/geode/io/mesh/assimp_input.cpp:58:54: warning: [readability-identifier-length]

parameter name 'v' is too short, expected at least 3 characters
```
   58 |             [&assimp_mesh, &builder]( geode::index_t v ) {
      |                                                      ^
```

src/geode/io/mesh/assimp_input.cpp:59:38: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   59 |                 const auto& vertex = assimp_mesh.mVertices[v];
      |                                      ^

src/geode/io/mesh/assimp_input.cpp:65:32: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic
```
   65 |             const auto& face = assimp_mesh.mFaces[p];
      |                                ^
```
src/geode/io/mesh/assimp_input.cpp:70:39: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic
```
   70 |                 polygon_vertices[i] = face.mIndices[i];
      |                                       ^
```

src/geode/io/mesh/assimp_input.cpp:79:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   79 | namespace geode
      | ^~~~~~~~~~~~~~~
   80 | {
      | ~
   81 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal

src/geode/io/mesh/assimp_input.cpp:89:32: warning: [readability-implicit-bool-conversion]

implicit conversion 'const aiScene *' -> 'bool'

   89 |             return Percentage{ assimp_scene ? 1. : 0. };
      |                                ^
      |                                (            != nullptr)

src/geode/io/mesh/assimp_input.cpp:108:39: warning: [readability-function-cognitive-complexity]

function 'read_textures' has cognitive complexity of 13 (threshold 10)

  108 |         void AssimpMeshInput< Mesh >::read_textures(
      |                                       ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:111:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  111 |             for( const auto i : Range{ assimp_scene->mNumMeshes } )
      |             ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:114:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  114 |                 if( !assimp_mesh.HasTextureCoords( 0 ) )
      |                 ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:122:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  122 |                 for( const auto p : Range{ assimp_mesh.mNumFaces } )
      |                 ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:125:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  125 |                     for( const auto v : LRange{ face.mNumIndices } )
      |                     ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:134:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  134 |                 if( !material.second.empty() )
      |                 ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:141:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  141 |                     catch( const OpenGeodeException& e )
      |                     ^

src/geode/io/mesh/assimp_input.cpp:113:44: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

  113 |                 const auto& assimp_mesh = *assimp_scene->mMeshes[i];
      |                                            ^

src/geode/io/mesh/assimp_input.cpp:124:40: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

  124 |                     const auto& face = assimp_mesh.mFaces[p];
      |                                        ^

src/geode/io/mesh/assimp_input.cpp:127:50: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

  127 |                         const auto mesh_vertex = face.mIndices[v];
      |                                                  ^

src/geode/io/mesh/assimp_input.cpp:129:29: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic
```
  129 |                             assimp_mesh.mTextureCoords[0][mesh_vertex];
      |                             ^
```

src/geode/io/mesh/assimp_input.cpp:159:46: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

  159 |                         build_mesh< Mesh >( *assimp_scene->mMeshes[i] );
      |                                              ^

src/geode/io/mesh/assimp_input.cpp:170:58: warning: [readability-function-cognitive-complexity]

function 'merge_meshes' has cognitive complexity of 15 (threshold 10)

  170 |         std::unique_ptr< Mesh > AssimpMeshInput< Mesh >::merge_meshes()
      |                                                          ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:175:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  175 |             for( const auto& surface : surfaces_ )
      |             ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:186:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  186 |             for( const auto s : Indices{ surfaces_ } )
      |             ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:190:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  190 |                 for( const auto name : manager.texture_names() )
      |                 ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:196:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  196 |                     for( const auto p : Range{ mesh->nb_polygons() } )
      |                     ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:200:25: note: +4, including nesting penalty of 3, nesting level increased to 4
  200 |                         if( merged_polygon == NO_ID )
      |                         ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/mesh/assimp_input.cpp:204:25: note: +4, including nesting penalty of 3, nesting level increased to 4
  204 |                         for( const auto v :
      |                         ^

src/geode/io/mesh/assimp_input.cpp:186:29: warning: [readability-identifier-length]

variable name 's' is too short, expected at least 3 characters
```
  186 |             for( const auto s : Indices{ surfaces_ } )
      |                             ^
```

src/geode/io/mesh/assimp_input.cpp:224:17: warning: [llvm-qualified-auto]

'const auto material' can be declared as 'auto *const material'

  224 |                 const auto material = assimp_scene->mMaterials[i];
      |                 ^~~~~~~~~~
      |                 auto *const

src/geode/io/mesh/assimp_input.cpp:224:39: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

  224 |                 const auto material = assimp_scene->mMaterials[i];
      |                                       ^

src/geode/io/mesh/assimp_input.cpp:234:26: warning: [readability-identifier-naming]

invalid case style for variable 'Path'

  234 |                 aiString Path;
      |                          ^~~~
      |                          path
  235 |                 if( material->GetTexture( aiTextureType_DIFFUSE, 0, &Path,
      |                                                                      ~~~~
      |                                                                      path
  236 |                         nullptr, nullptr, nullptr, nullptr, nullptr )
  237 |                     == AI_SUCCESS )
  238 |                 {
  239 |                     materials_[i].second = absl::StrCat(
  240 |                         filepath_without_filename( file_ ).string(),
  241 |                         Path.C_Str() );
      |                         ~~~~
      |                         path

src/geode/io/model/vtm_brep_output.cpp:71:14: warning: [readability-function-cognitive-complexity]

function 'write_blocks' has cognitive complexity of 13 (threshold 10)

   71 |         void write_blocks( pugi::xml_node& block_block )
      |              ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:80:13: note: +1, including nesting penalty of 0, nesting level increased to 1
   80 |             for( const auto& block : mesh().blocks() )
      |             ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:86:13: note: +1, including nesting penalty of 0, nesting level increased to 1
   86 |             for( const auto& id : block_ids )
      |             ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:97:17: note: +2, including nesting penalty of 1, nesting level increased to 2
   97 |                 if( is_new )
      |                 ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:102:17: note: +1, nesting level increased to 2
  102 |                 else
      |                 ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:109:50: note: nesting level increased to 2
  109 |                 tasks[counter++] = async::spawn( [&block, this] {
      |                                                  ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:113:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  113 |                     if( const auto* tetra =
      |                     ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:120:26: note: +1, nesting level increased to 3
  120 |                     else if( const auto* hybrid =
      |                          ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:127:26: note: +1, nesting level increased to 3
  127 |                     else if( const auto* poly = dynamic_cast<
      |                          ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:133:26: note: +1, nesting level increased to 3
  133 |                     else if( const auto* grid =
      |                          ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:140:21: note: +1, nesting level increased to 3
  140 |                     else
      |                     ^
/__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/vtm_brep_output.cpp:152:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  152 |             for( auto& task : all_tasks.get() )
      |             ^

src/geode/io/model/vtm_brep_output.cpp:86:30: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
   86 |             for( const auto& id : block_ids )
      |                              ^
```

src/geode/io/model/vtm_brep_output.cpp:160:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

  160 | namespace geode
      | ^~~~~~~~~~~~~~~
  161 | {
      | ~
  162 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail
  163 |     {
  164 |         std::vector< std::string > VTMBRepOutput::write(
  165 |             const BRep& brep ) const
  166 |         {
  167 |             VTMBRepOutputImpl impl{ filename(), brep };
  168 |             impl.write_file();
  169 |             return impl.files();
  170 |         }
  171 |     } // namespace detail
      |     ~~~~~~~~~~~~~~~~~~~~~
      |     } // namespace geode::detail
  172 | } // namespace geode
      | ~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

BotellaA · 2026-08-18T15:53:26Z

🎉 This PR is included in version 7.8.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

BotellaA · 2026-08-19T00:32:30Z

🎉 This PR is included in version 7.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fix(Logger): replace warn with warning

a93a751

BenPinet requested a review from BotellaA August 3, 2026 10:08

BotellaA approved these changes Aug 3, 2026

View reviewed changes

BotellaA merged commit f9c2191 into v18 Aug 3, 2026
20 of 24 checks passed

BotellaA deleted the feat/replace_replace_warn_with_warning branch August 3, 2026 14:34

BotellaA added the released on @next label Aug 18, 2026

BotellaA added the released label Aug 19, 2026

Navigation Menu

Uh oh!

Uh oh!

fix(Logger): replace warn with warning - #197

fix(Logger): replace warn with warning#197
BotellaA merged 1 commit into
v18from
feat/replace_replace_warn_with_warning

BenPinet commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

Uh oh!

BotellaA commented Aug 18, 2026

Uh oh!

BotellaA commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

BenPinet commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Cpp-Linter Report ⚠️

Uh oh!

Uh oh!

BotellaA commented Aug 18, 2026

Uh oh!

BotellaA commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants