Skip to content

fix(Logger): replace warn with warning #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 1 commit into from
Aug 3, 2026
Merged

fix(Logger): replace warn with warning #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/geode/io/model/detail/vtm_output.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
#include <geode/io/image/detail/vtk_output.hpp>
#include <geode/io/model/common.hpp>

namespace geode

Check warning on line 57 in include/geode/io/model/detail/vtm_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/model/detail/vtm_output.hpp:57:1 [modernize-concat-nested-namespaces] 

nested namespaces can be concatenated
{
namespace detail
{
Expand Down Expand Up @@ -109,12 +109,12 @@
return counter;
}

std::string_view prefix() const

Check warning on line 112 in include/geode/io/model/detail/vtm_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/model/detail/vtm_output.hpp:112:13 [modernize-use-nodiscard] 

function 'prefix' should be marked [[nodiscard]]
{
return prefix_;
}

std::string_view files_directory() const

Check warning on line 117 in include/geode/io/model/detail/vtm_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/model/detail/vtm_output.hpp:117:13 [modernize-use-nodiscard] 

function 'files_directory' should be marked [[nodiscard]]
{
return files_directory_;
}
Expand All @@ -129,7 +129,7 @@
{
index_t counter{ 0 };
const auto level = Logger::level();
Logger::set_level( Logger::LEVEL::warn );
Logger::set_level( Logger::LEVEL::warning );
absl::FixedArray< async::task< void > > tasks(
this->mesh().nb_corners() );
absl::FixedArray< uuid > corner_ids(
Expand All @@ -141,7 +141,7 @@
}
absl::c_sort( corner_ids );
absl::flat_hash_set< std::string > corner_name_counter;
for( const auto& id : corner_ids )

Check warning on line 144 in include/geode/io/model/detail/vtm_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/model/detail/vtm_output.hpp:144:34 [readability-identifier-length] 

variable name 'id' is too short, expected at least 3 characters
{
const auto& corner = this->mesh().corner( id );
auto dataset = corner_block.append_child( "DataSet" );
Expand Down Expand Up @@ -187,7 +187,7 @@
{
index_t counter{ 0 };
const auto level = Logger::level();
Logger::set_level( Logger::LEVEL::warn );
Logger::set_level( Logger::LEVEL::warning );
absl::FixedArray< async::task< void > > tasks(
this->mesh().nb_lines() );
absl::FixedArray< uuid > line_ids( this->mesh().nb_lines() );
Expand All @@ -198,7 +198,7 @@
}
absl::c_sort( line_ids );
absl::flat_hash_set< std::string > line_name_counter;
for( const auto& id : line_ids )

Check warning on line 201 in include/geode/io/model/detail/vtm_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/model/detail/vtm_output.hpp:201:34 [readability-identifier-length] 

variable name 'id' is too short, expected at least 3 characters
{
const auto& line = this->mesh().line( id );
auto dataset = line_block.append_child( "DataSet" );
Expand Down Expand Up @@ -239,11 +239,11 @@
}
}

void write_surfaces( pugi::xml_node& surface_block )

Check warning on line 242 in include/geode/io/model/detail/vtm_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/model/detail/vtm_output.hpp:242:18 [readability-function-cognitive-complexity] 

function 'write_surfaces' has cognitive complexity of 12 (threshold 10)
{
index_t counter{ 0 };
const auto level = Logger::level();
Logger::set_level( Logger::LEVEL::warn );
Logger::set_level( Logger::LEVEL::warning );
absl::FixedArray< async::task< void > > tasks(
this->mesh().nb_surfaces() );
absl::FixedArray< uuid > surface_ids(
Expand All @@ -255,7 +255,7 @@
}
absl::c_sort( surface_ids );
absl::flat_hash_set< std::string > surface_name_counter;
for( const auto& id : surface_ids )

Check warning on line 258 in include/geode/io/model/detail/vtm_output.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

include/geode/io/model/detail/vtm_output.hpp:258:34 [readability-identifier-length] 

variable name 'id' is too short, expected at least 3 characters
{
const auto& surface = this->mesh().surface( id );
auto dataset = surface_block.append_child( "DataSet" );
Expand Down
2 changes: 1 addition & 1 deletion src/geode/io/mesh/assimp_input.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@
builder->create_vertices( assimp_mesh.mNumVertices );
async::parallel_for(
async::irange( geode::index_t{ 0 }, assimp_mesh.mNumVertices ),
[&assimp_mesh, &builder]( geode::index_t v ) {

Check warning on line 58 in src/geode/io/mesh/assimp_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/mesh/assimp_input.cpp:58:54 [readability-identifier-length] 

parameter name 'v' is too short, expected at least 3 characters
const auto& vertex = assimp_mesh.mVertices[v];

Check warning on line 59 in src/geode/io/mesh/assimp_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/mesh/assimp_input.cpp:59:38 [cppcoreguidelines-pro-bounds-pointer-arithmetic] 

do not use pointer arithmetic
builder->set_point(
v, geode::Point3D{ { vertex.x, vertex.y, vertex.z } } );
} );
for( const auto p : geode::Range{ assimp_mesh.mNumFaces } )
{
const auto& face = assimp_mesh.mFaces[p];

Check warning on line 65 in src/geode/io/mesh/assimp_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/mesh/assimp_input.cpp:65:32 [cppcoreguidelines-pro-bounds-pointer-arithmetic] 

do not use pointer arithmetic
absl::FixedArray< geode::index_t > polygon_vertices(
face.mNumIndices );
for( const auto i : geode::LIndices{ polygon_vertices } )
Expand Down Expand Up @@ -140,7 +140,7 @@
}
catch( const OpenGeodeException& e )
{
Logger::warn( e.what() );
Logger::warning( e.what() );
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/geode/io/model/vtm_brep_output.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ namespace
{
geode::index_t counter{ 0 };
const auto level = geode::Logger::level();
geode::Logger::set_level( geode::Logger::LEVEL::warn );
geode::Logger::set_level( geode::Logger::LEVEL::warning );
absl::FixedArray< async::task< void > > tasks( mesh().nb_blocks() );
absl::FixedArray< geode::uuid > block_ids(
this->mesh().nb_blocks() );
Expand Down
Loading