Skip to content

feat(Attribute): attribute filtering on import - #1277

Merged
BotellaA merged 1 commit into
Geode-solutions:fix/import-filter-attribuesfrom
yo35:import-with-attribute-filtering
May 29, 2026
Merged

feat(Attribute): attribute filtering on import#1277
BotellaA merged 1 commit into
Geode-solutions:fix/import-filter-attribuesfrom
yo35:import-with-attribute-filtering

Conversation

@yo35

@yo35 yo35 commented May 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@yo35

yo35 commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

An alternative implementation could be to add an overload of the import(..) methods with an additional argument std::string_view attribute_name, and to let the caller import attributes one by one. Maybe this is better than what I propose here.

@BotellaA
BotellaA changed the base branch from master to fix/import-filter-attribues May 29, 2026 06:53
@BotellaA
BotellaA merged commit bf398f6 into Geode-solutions:fix/import-filter-attribues May 29, 2026
5 of 7 checks passed
@yo35 yo35 mentioned this pull request May 29, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yo35 @BotellaA