Repository navigation
feat: report the inline banner's height (setBannerHeightChangedCallback) - #53
Merged
Merged
Conversation
…r content below it setBannerHeightChangedCallback reports the space an inline banner takes at the top of the screen (dp): on show, resize and rotation, 0 on close or replace (not on the overlay rebuild for another activity). Floating banners report 0. getBannerHeight returns the current value. In edge-to-edge apps the inline banner now covers the status bar in its color, like on iOS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer ask (Operátor ICT, ticket 129428): in Flutter, inline banners cover the app instead of pushing it down like on the web. This adds the native signal the Flutter SDK needs (GleapSDK/Flutter-SDK PR on
feat/inline-banner-inset); iOS has the same in GleapSDK/Gleap-iOS-SDK.API
Gleap.getInstance().setBannerHeightChangedCallback(BannerHeightChangedCallback)— dp from the top of the content that the inline banner covers. Fires on show, on resize (layout listener: banner page height, rotation, insets) and with 0 on close / replace /clearIdentity. Not on the overlay rebuild when another activity resumes (the banner comes back there), so content doesn't jump when returning from the widget. Floating banners report 0. Only changes are reported.Gleap.getInstance().getBannerHeight()— the current value, for listeners that start later.Visual change: in edge-to-edge apps the inline banner now reaches up under the status bar in the banner color (padding + translationY, overlay
clipToPadding=false), like on iOS, instead of leaving app content showing above it. Apps that aren't edge-to-edge get no top inset, so nothing changes there. Floating banners are untouched.Tested (Flutter example on the Medium Phone API 36.1 emulator against this branch published to mavenLocal, banner fed through
GleapOverlayManager.showBannerwith a real inline payload, at targetSdk 33 and 35 (forced edge-to-edge)):getBannerHeight():gleap:testDebugUnitTestpassesShips with the next synchronized SDK release (
## Unreleasedin CHANGELOG).🤖 Generated with Claude Code