Repository navigation
feat: report the inline banner's height (bannerHeightChanged:) - #58
Merged
Merged
Conversation
…r content below it New GleapDelegate method bannerHeightChanged: with the space an inline banner takes at the top of the window (points from the top edge, status bar included): on show, resize and rotation, 0 on close or replace. Floating banners report 0. Gleap.bannerHeight returns the current value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer ask (Operátor ICT, ticket 129428): in Flutter, inline banners cover the app instead of pushing it down like on the web. This adds the native signal the Flutter SDK needs (GleapSDK/Flutter-SDK PR on
feat/inline-banner-inset); Android has the same in GleapSDK/Android-SDK.API
GleapDelegate- (void)bannerHeightChanged:(CGFloat)height— points from the top of the window that the inline banner covers (status bar included, since the banner reaches under it). Fires on show, on resize (banner page height, rotation vialayoutSubviews), and with 0 on close or when replaced. Floating banners report 0. Only changes are reported.+ (CGFloat)bannerHeight— the current value, for listeners that start later (Flutter hot restart / new engine).No visual change for native apps.
Tested (Flutter example on iPhone 17 Pro sim, iOS 27, against this branch via a local SPM path, banner fed through
GleapUIOverlayHelper showBanner:with a real inline payload):bannerHeightxcodebuild test: 131 tests, 0 failuresShips with the next synchronized SDK release (
## Unreleasedin CHANGELOG).🤖 Generated with Claude Code