Skip to content

Remove logic to automatically infer where end segments are #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephenCWills wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove logic to automatically infer where end segments are #711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions Source/Libraries/openXDA.Model/TransmissionElements/Line.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,9 @@ private List<LineSegment> QuerySegments()
private List<TransmissionPath> QueryPath()
{
// Start by finding all the ends
bool IsEnd(LineSegment segment) =>
static bool IsEnd(LineSegment segment) =>
segment.IsEnd ||
segment.ConnectedSegments.Count <= 1 ||
IsForkedEnd(segment);
segment.ConnectedSegments.Count == 0;

List<LineSegment> lineEnds = [.. Segments.Where(IsEnd)];

Expand Down Expand Up @@ -192,22 +191,6 @@ bool IsEnd(LineSegment segment) =>
}).OrderByDescending(item => item.Length).ToList();
}

/// <summary>
/// Determines if all pairs of segments connected to the given segment are connected to each other.
/// </summary>
private bool IsForkedEnd(LineSegment segment)
{
bool AreDirectConnected(LineSegment s1, LineSegment s2) => s1.ConnectedSegments
.Any(connection => connection.ParentSegment == s2.ID || connection.ChildSegment == s2.ID);

List<LineSegment> nextSegments = [.. GetNextSegments(segment)];

return nextSegments
.SelectMany(_ => nextSegments, (S1, S2) => (S1, S2))
.Where(tuple => tuple.S1.ID < tuple.S2.ID)
.All(tuple => AreDirectConnected(tuple.S1, tuple.S2));
}

/// <summary>
/// Attempts to walk the line from start to end.
/// </summary>
Expand Down