fix(grading): committed .env / hardcoded connection string is now a hard-fail blocker#2
Open
lassebenni wants to merge 1 commit into
Open
fix(grading): committed .env / hardcoded connection string is now a hard-fail blocker#2lassebenni wants to merge 1 commit into
lassebenni wants to merge 1 commit into
Conversation
A committed week11-streamlit/.env or a hardcoded Postgres connection string in app.py previously only cost 5 points inside Level 2, so a student could still pass overall with a leaked password. Add a blocker() helper to grader_lib.sh that forces write_score() to report pass=false regardless of score, and wire it into both secrets checks. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
week11-streamlit/.envor hardcoded a Postgres connection string inapp.pypreviously only lost 5/15 Level 2 points and could still pass overall.blocker()helper tograder_lib.sh(same pattern as week 10's fix): prints likefail()but forceswrite_score()to reportpass=falseno matter the point total.blocker()and tell the student to rotate the password since it was pushed to GitHub.Test plan
bash -n .hyf/test.sh/bash -n .hyf/grader_lib.sh🤖 Generated with Claude Code