Skip to content

fix(grading): committed .env / hardcoded connection string is now a hard-fail blocker #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lassebenni wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(grading): committed .env / hardcoded connection string is now a hard-fail blocker #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .hyf/grader_lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,23 @@
# Source this at the top of test.sh:
# source "$(dirname "$0")/grader_lib.sh"
#
# Provides: pass(), fail(), warn(), print_results(), write_score(),
# Provides: pass(), fail(), warn(), blocker(), print_results(), write_score(),
# and a set of common static-analysis checks derived from recurring
# PR review patterns across cohort c55.
#
# blocker(): use for leaked-secret findings (a committed profiles.yml/.env,
# a hardcoded password/connection string). It behaves like fail() for the
# printed report, but also flips a flag that forces write_score() to report
# pass=false regardless of the earned point total -- a leaked secret must
# be fixed before the PR can pass, it cannot be "pointed around."

_grader_details=()
_grader_blocker=false

pass() { _grader_details+=("✓ PASS $1"); }
fail() { _grader_details+=("✗ FAIL $1"); }
warn() { _grader_details+=("⚠ WARN $1"); }
blocker() { _grader_details+=("🚫 BLOCKER $1"); _grader_blocker=true; }

print_results() {
local header="${1:-Autograder Results}"
Expand All @@ -28,6 +36,10 @@ write_score() {
local outfile="${3:-$(dirname "${BASH_SOURCE[0]}")/score.json}"
local pass_flag="false"
[[ "$score" -ge "$passing" ]] && pass_flag="true"
if [[ "$_grader_blocker" == true ]]; then
pass_flag="false"
echo "🚫 A blocker was found (leaked secret) -- forcing pass=false regardless of score." >&2
fi
cat > "$outfile" << JSON
{
"score": $score,
Expand Down
4 changes: 2 additions & 2 deletions .hyf/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ else
fi

if [[ -f "$APP_DIR/.env" ]]; then
fail "week11-streamlit/.env is committed -- BLOCKER: run: git rm --cached week11-streamlit/.env"
blocker "week11-streamlit/.env is committed -- run: git rm --cached week11-streamlit/.env, then rotate the Postgres password since it was pushed"
else
((l2 += 5)); pass "week11-streamlit/.env not committed"
fi

if [[ -f "$app" ]] && grep -qE "postgresql://[^\"'[:space:]]*:[^\"'[:space:]]*@" "$app"; then
fail "app.py: hardcoded Postgres connection string with an inline password -- use os.environ/os.getenv instead"
blocker "app.py: hardcoded Postgres connection string with an inline password -- use os.environ/os.getenv instead, then rotate the password since it was pushed"
elif [[ -f "$app" ]]; then
((l2 += 5)); pass "app.py: no hardcoded Postgres credentials found"
fi
Expand Down