Conversation
Member
Author
Member
Author
julianbrost
requested changes
Jul 4, 2023
Member
|
Should be fine now, just misses release date, removing the commit disabling GitHub Actions and general cleanup of the commit history. |
This reverts commit 976e6fe.
julianbrost
reviewed
Jul 7, 2023
Comment on lines
+136
to
+183
| ### ITL | ||
|
|
||
| Add linux\_netdev check command. #9045 | ||
|
|
||
| #### Command Argument Changes | ||
|
|
||
| * disk: don't pass -m (disk\_megabytes) by default. #9642 | ||
| * disk: pass -X fuse.portal (disk\_exclude\_type) by default. #9459 | ||
| * http: support multiple -k (http\_header) as array. #8574 | ||
| * icmp: double defaults for -w (icmp\_wpl) and -c (icmp\_cpl). #9041 | ||
| * logfiles: pass --winwarncrit (logfiles\_winwarncrit) without argument. #9056 | ||
| * nwc\_health: pass SNMPv3-only args only when using SNMPv3. #9095 | ||
| * vmware-esx-dc-runtime-tools and vmware-esx-soap-vm-runtime-tools: | ||
| rename --open-vm-tools to --open\_vm\_tools\_ok (vmware\_openvmtools). #9611 | ||
|
|
||
| #### New Command Arguments | ||
|
|
||
| | Command | Argument | Custom Variable | PR | | ||
| |----------------------------------|----------------------------|------------------------------------------|-------| | ||
| | disk | -P | disk\_inode\_perfdata | #9494 | | ||
| | esxi\_hardware | --format | esxi\_hardware\_format | #9435 | | ||
| | esxi\_hardware | --pretty | esxi\_hardware\_pretty | #9435 | | ||
| | http | --verify-host | http\_verify\_host | #8005 | | ||
| | icingacli-businessprocess | --ack-is-ok | icingacli\_businessprocess\_ackisok | #9103 | | ||
| | icingacli-businessprocess | --blame | icingacli\_businessprocess\_blame | #9103 | | ||
| | icingacli-businessprocess | --colors | icingacli\_businessprocess\_colors | #9103 | | ||
| | icingacli-businessprocess | --downtime-is-ok | icingacli\_businessprocess\_downtimeisok | #9103 | | ||
| | icingacli-businessprocess | --root-cause | icingacli\_businessprocess\_rootcause | #9103 | | ||
| | mem | -a | mem\_available | #9385 | | ||
| | mongodb | --disable\_retry\_writes | mongodb\_disableretrywrites | #9539 | | ||
| | mongodb | --ssl-ca-cert-file | mongodb\_ssl\_ca\_cert\_file | #9610 | | ||
| | mysql | --extra-opts | mysql\_extra\_opts | #9197 | | ||
| | nrpe | -3 | nrpe\_version\_3 | #9296 | | ||
| | nrpe | -D | nrpe\_no\_logging | #9016 | | ||
| | nrpe | -P | nrpe\_payload\_size | #9032 | | ||
| | pgsql | --extra-opts | pgsql\_extra\_opts | #9197 | | ||
| | postgres | $PGCONTROLDATA (env. var.) | postgres\_pgcontroldata | #8929 | | ||
| | postgres | --datadir | postgres\_datadir | #8924 | | ||
| | postgres | --language | postgres\_language | #8924 | | ||
| | postgres | --perflimit | postgres\_perflimit | #8924 | | ||
| | ssl\_cert | --ignore-host-cn | ssl\_cert\_ignore\_host\_cn | #9512 | | ||
| | ssl\_cert | --ignore-ocsp-errors | ssl\_cert\_ignore\_ocsp\_errors | #9512 | | ||
| | ssl\_cert | --ignore-ocsp-timeout | ssl\_cert\_ignore\_ocsp\_timeout | #9512 | | ||
| | ssl\_cert | --ignore-tls-renegotiation | ssl\_cert\_ignore\_tls\_renegotiation | #9042 | | ||
| | ssl\_cert | --proxy | ssl\_cert\_proxy | #8927 | | ||
| | tcp | --sni | tcp\_sni | #9347 | | ||
| | vmware-esx-dc-runtime-tools | --no\_vm\_tools\_ok | vmware\_novmtools | #9611 | | ||
| | vmware-esx-soap-vm-runtime-tools | --no\_vm\_tools\_ok | vmware\_novmtools | #9611 | |
Member
There was a problem hiding this comment.
Can we use `foo_bar` instead of foo\_bar instead? IMHO this would make it more pleasant to read in the plain text form and also is more grep-friendly.
Member
Author
There was a problem hiding this comment.
I could do this, but this would enlarge the table further. see also doc/ITL/disk
Member
There was a problem hiding this comment.
see also doc/ITL/disk
Either I don't understand what you're referring to or what I should see there.
| #### API | ||
|
|
||
| * Disallow breaking inter-object relationships by changing | ||
| relationship attributes at runtime, e.g. Service#host_name. #9407 |
Member
There was a problem hiding this comment.
Also, there is a single unescaped _ here.
julianbrost
previously approved these changes
Jul 10, 2023
4 tasks
julianbrost
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.