Skip to content

feat(ui): show just "QuickPlay" in the player's title bar - #12

Merged
InstaZDLL merged 1 commit into
mainfrom
feat/bar-title-quickplay
Oct 23, 2026
Merged

InstaZDLL merged 1 commit into
mainfrom
feat/bar-title-quickplay

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

The player's painted title bar now reads QuickPlay instead of WaveFlow QuickPlay. The logo beside it already says WaveFlow and the about block gives the full name, so the room goes to the track's title.

  • A new BAR_TITLE constant in src/app.rs is what the bar paints.
  • The OS window title stays MAIN_TITLE ("WaveFlow QuickPlay"): on Windows the playlist window finds the player by it to become its owned window.
  • Checked with a capture of the running player; fmt, clippy -D warnings and the 39 tests pass.

Summary by CodeRabbit

  • Améliorations
    • Le lecteur affiche désormais « QuickPlay » dans sa barre de titre.

The logo beside it already says WaveFlow and the about block gives the
full name, so the bar leaves the room to the track's title. The OS window
title stays "WaveFlow QuickPlay": the playlist window finds the player
by it on Windows.
@github-actions github-actions Bot added scope: ui Windows, widgets, player and playlist panes, settings page (src/ui, app.rs, platform.rs) type: feat New feature size: xs < 10 lines labels Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between e40d07c and 4f3e9b4.

📒 Files selected for processing: 1
  • src/app.rs

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

📝 Walkthrough

Le titre affiché dans la barre du lecteur est maintenant « QuickPlay ». Le titre de la fenêtre du système reste distinct.

Changes: Titre du lecteur

Layer / File(s) Summary
Définition et utilisation du titre de la barre
src/app.rs
La constante privée BAR_TITLE vaut « QuickPlay ». widgets::title_bar reçoit désormais cette constante à la place de MAIN_TITLE.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested labels: scope: ui, size: s

Merge Risk: ⚪ Minimal · up to 4f3e9

No actionable merge-blocking risk remains.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed Le titre respecte Conventional Commits et décrit clairement le changement principal de l’interface : afficher uniquement « QuickPlay » dans la barre du lecteur.
Description check Passed La description explique le changement, sa justification, la conservation de MAIN_TITLE et les vérifications effectuées. Elle ne reprend pas les sections formelles du modèle pour la capture, la checkli…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

La description explique le changement, sa justification, la conservation de MAIN_TITLE et les vérifications effectuées. Elle ne reprend pas les sections formelles du modèle pour la capture, la checklist et les issues liées, mais les informations principales sont présentes.

✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@InstaZDLL InstaZDLL self-assigned this Oct 23, 2026
@InstaZDLL
InstaZDLL merged commit 3681a29 into main Oct 23, 2026
5 checks passed
@InstaZDLL
InstaZDLL deleted the feat/bar-title-quickplay branch October 23, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: ui Windows, widgets, player and playlist panes, settings page (src/ui, app.rs, platform.rs) size: xs < 10 lines type: feat New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant