Skip to content

chore(license): GPL-3.0-only, not "or later" - #16

Merged
InstaZDLL merged 1 commit into
mainfrom
chore/license-gpl3-only
Oct 25, 2026
Merged

InstaZDLL merged 1 commit into
mainfrom
chore/license-gpl3-only

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • The licence is GPL-3.0-only. Cargo.toml, the .rpm, the macOS Info.plist and CONTRIBUTING already said so, but the README notice granted "version 3 of the License, or (at your option) any later version". The notice now says "version 3 of the License only".
  • The README badge and the licence line of the about block, in all eight languages, now say GPL-3.0-only.
  • LICENSE is unchanged: the GPL text with the copyright line at its top.

Breaking: none.

How I tested

  • cargo fmt --check, clippy -D warnings and cargo test on Windows 11.
  • No "any later version" is left outside the GPL text itself.

Not covered: docs/screenshots/settings.png still shows "GPL-3.0" in the about block.

Screenshots / clips

None.

Checklist

  • Title uses Conventional Commits (type(scope): subject, kebab-case scope)
  • cargo fmt --check, cargo clippy --locked --all-targets -- -D warnings and cargo test --locked pass locally
  • If UI strings changed: every language in src/i18n/ updated, placeholders kept
  • If a cross-cutting pattern changed: docs/ARCHITECTURE.md updated
  • Platform-specific behaviour: tested on the platform(s) named above
  • Breaking change (settings file, CLI flags, IPC protocol)? Called out in the summary

Linked issues

None.

Summary by CodeRabbit

  • Documentation
    • Le README précise que le projet est soumis exclusivement à la licence GNU GPL version 3, sans possibilité d’appliquer une version ultérieure.

The manifests, the packages and CONTRIBUTING already said GPL-3.0-only,
but the README notice granted "version 3 or (at your option) any later
version". The notice now says version 3 only, and the badge and the
about block in every language say GPL-3.0-only.
@github-actions github-actions Bot added scope: i18n Translations (src/i18n/) scope: docs Docs, README, release notes type: chore Maintenance / tooling size: s 10-50 lines labels Oct 25, 2026
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between aa02fdc and 0004413.

Files ignored due to path filters: 8
  • src/i18n/de.rs is excluded by !src/i18n/*.rs
  • src/i18n/en.rs is excluded by !src/i18n/*.rs
  • src/i18n/es.rs is excluded by !src/i18n/*.rs
  • src/i18n/fr.rs is excluded by !src/i18n/*.rs
  • src/i18n/it.rs is excluded by !src/i18n/*.rs
  • src/i18n/ja.rs is excluded by !src/i18n/*.rs
  • src/i18n/ko.rs is excluded by !src/i18n/*.rs
  • src/i18n/zh_cn.rs is excluded by !src/i18n/*.rs
Files selected for processing: 1
  • README.md

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Walkthrough

Le README indique désormais GPL-3.0-only dans son badge et précise que le programme est régi uniquement par la version 3 de la GNU GPL.

Changes: Déclaration de licence

Layer / File(s) Summary
Mise à jour du badge et de la notice
README.md
Le badge et la notice indiquent une licence limitée à la version 3 de la GNU GPL.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

  • InstaZDLL/waveflow-quickplay#14 : cette PR corrige la même incohérence entre la licence indiquée dans le README et celle déclarée dans les autres fichiers.

Suggested labels: type: chore, scope: docs, scope: i18n, size: xs

Merge Risk: Minimal · up to 00044

The license declaration is consistent and presents no actionable merge risk.

Architecture risk: Low · up to 00044

The change affects 1 system.

Changed systems: README.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — README.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in README.md: Le badge de licence passe de GPL-3.0 à GPL-3.0-only.
  • observed — Modified behavior in README.md: La notice remplace l’option « version 3 ou toute version ultérieure » par une licence limitée à la version 3.
Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed Le titre décrit clairement la modification principale et respecte le format Conventional Commits avec le scope license.
Description check Passed La description contient le résumé, les tests exécutés, les limites connues, la checklist et l’absence de changement majeur. Elle correspond aux changements décrits.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@InstaZDLL InstaZDLL self-assigned this Oct 25, 2026
@InstaZDLL
InstaZDLL merged commit e3f9178 into main Oct 25, 2026
6 checks passed
@InstaZDLL
InstaZDLL deleted the chore/license-gpl3-only branch October 25, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: docs Docs, README, release notes scope: i18n Translations (src/i18n/) size: s 10-50 lines type: chore Maintenance / tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant